From: Michael Ellerman <mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
To: Kees Cook <keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
Cc: Linux API <linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Robert Sesek <rsesek-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Bamvor Jian Zhang
<bamvor.zhangjian-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v2] selftests/seccomp: Get page size from sysconf
Date: Mon, 16 Nov 2015 16:42:21 +1100 [thread overview]
Message-ID: <1447652541.959.8.camel@ellerman.id.au> (raw)
In-Reply-To: <CAGXu5jJxxtfOfUzjWByh+wyVb56U2k42SneLnnE8dST8r_Yz=A@mail.gmail.com>
On Fri, 2015-11-13 at 14:41 -0800, Kees Cook wrote:
> On Thu, Nov 12, 2015 at 7:17 PM, Bamvor Jian Zhang
> <bamvor.zhangjian-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> > The commit fd88d16c58c2 ("selftests/seccomp: Be more precise with
> > syscall arguments.") use PAGE_SIZE directly which lead to build
> > failure on arm64.
> >
> > Replace it with generic interface(sysconf(_SC_PAGESIZE)) to fix this
> > failure.
> >
> > Build and test successful on x86_64 and arm64.
> >
> > Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>
> Acked-by: Kees Cook <keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
>
> Shuah, can you please pull this for kselftest? It fixes arm64 after
> Robert's changes.
Also works on powerpc with 64k pages.
Tested-by: Michael Ellerman <mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
cheers
next prev parent reply other threads:[~2015-11-16 5:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 3:17 [PATCH v2] selftests/seccomp: Get page size from sysconf Bamvor Jian Zhang
[not found] ` <1447384671-17758-1-git-send-email-bamvor.zhangjian-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-11-13 22:41 ` Kees Cook
2015-11-16 5:42 ` Michael Ellerman [this message]
2015-11-17 2:26 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447652541.959.8.camel@ellerman.id.au \
--to=mpe-gsx/oe8hsfggbc27wqdahg@public.gmane.org \
--cc=bamvor.zhangjian-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rsesek-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).