From: Marc Titinger <mtitinger@baylibre.com>
To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net
Cc: daniel.baluta@intel.com, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
Marc Titinger <mtitinger@baylibre.com>
Subject: [RFC 1/2] ABI: iio: support AVERAGING_RATIO setting
Date: Tue, 17 Nov 2015 11:44:09 +0100 [thread overview]
Message-ID: <1447757050-4214-2-git-send-email-mtitinger@baylibre.com> (raw)
In-Reply-To: <1447757050-4214-1-git-send-email-mtitinger@baylibre.com>
Some ADC devices allow averaging/downsampling. The minimal parameter
set for this will be the number of taps used for computing a mean value.
In some cases the ratio will hold discrete values for instance "1, 4, 16"
hence an averaging_ratio_available property is useful. The possible ratio
values are less likely to changing with the device settings, so this patch
only provides a CONST version of the definition helper.
Tested with ina226:
# ls /sys/bus/iio/devices/iio\:device0/
averaging_ratio_available in_voltage0_raw
dev in_voltage1_raw
in_averaging_ratio name
in_calibscale power
in_current2_raw sampling_frequency_available
in_power3_raw subsystem
in_sampling_frequency uevent
# cat averaging_ratio_available
1, 4, 16, 64, 128, 256, 512, 1024
Signed-off-by: Marc Titinger <mtitinger@baylibre.com>
---
Documentation/ABI/testing/sysfs-bus-iio | 13 +++++++++++++
drivers/iio/industrialio-core.c | 1 +
include/linux/iio/iio.h | 1 +
include/linux/iio/sysfs.h | 9 +++++++++
4 files changed, 24 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
index 42d360f..a208dfe 100644
--- a/Documentation/ABI/testing/sysfs-bus-iio
+++ b/Documentation/ABI/testing/sysfs-bus-iio
@@ -56,6 +56,19 @@ Description:
When the internal sampling clock can only take a small
discrete set of values, this file lists those available.
+What: /sys/bus/iio/devices/iio:deviceX/averaging_ratio
+KernelVersion: 4.x.x
+Contact: linux-iio@vger.kernel.org
+Description:
+ Hardware dependent ADC averaging. Controls the averaging ratio
+ of the digital filter if available.
+
+What: /sys/bus/iio/devices/iio:deviceX/averaging_ratio_available
+KernelVersion: 4.x.x
+Contact: linux-iio@vger.kernel.org
+Description:
+ Hardware dependent values supported by the averaging filter.
+
What: /sys/bus/iio/devices/iio:deviceX/oversampling_ratio
KernelVersion: 2.6.38
Contact: linux-iio@vger.kernel.org
diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
index b3fcc2c..e4745f0 100644
--- a/drivers/iio/industrialio-core.c
+++ b/drivers/iio/industrialio-core.c
@@ -142,6 +142,7 @@ static const char * const iio_chan_info_postfix[] = {
[IIO_CHAN_INFO_DEBOUNCE_TIME] = "debounce_time",
[IIO_CHAN_INFO_CALIBEMISSIVITY] = "calibemissivity",
[IIO_CHAN_INFO_OVERSAMPLING_RATIO] = "oversampling_ratio",
+ [IIO_CHAN_INFO_AVERAGING_RATIO] = "averaging_ratio",
};
/**
diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
index 7bb7f67..4c84de5 100644
--- a/include/linux/iio/iio.h
+++ b/include/linux/iio/iio.h
@@ -46,6 +46,7 @@ enum iio_chan_info_enum {
IIO_CHAN_INFO_DEBOUNCE_TIME,
IIO_CHAN_INFO_CALIBEMISSIVITY,
IIO_CHAN_INFO_OVERSAMPLING_RATIO,
+ IIO_CHAN_INFO_AVERAGING_RATIO,
};
enum iio_shared_by {
diff --git a/include/linux/iio/sysfs.h b/include/linux/iio/sysfs.h
index 9cd8f74..4478ba1 100644
--- a/include/linux/iio/sysfs.h
+++ b/include/linux/iio/sysfs.h
@@ -76,6 +76,15 @@ struct iio_const_attr {
/* Generic attributes of onetype or another */
/**
+ * IIO_CONST_ATTR_AVERAGING_RATIO_AVAIL - list available averaging ratios
+ * @_string: ratio string for the attribute
+ *
+ * Constant version
+ **/
+#define IIO_CONST_ATTR_AVERAGING_RATIO_AVAIL(_string) \
+ IIO_CONST_ATTR(averaging_ratio_available, _string)
+
+/**
* IIO_DEV_ATTR_SAMP_FREQ - sets any internal clock frequency
* @_mode: sysfs file mode/permissions
* @_show: output method for the attribute
--
1.9.1
next prev parent reply other threads:[~2015-11-17 10:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 10:44 [RFC 0/2] ABI: IIO: proposal for AVERAGING_RATIO support Marc Titinger
2015-11-17 10:44 ` Marc Titinger [this message]
2015-11-17 13:39 ` [RFC 1/2] ABI: iio: support AVERAGING_RATIO setting jic23
2015-11-17 14:04 ` Marc Titinger
[not found] ` <1447757050-4214-1-git-send-email-mtitinger-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2015-11-17 10:44 ` [RFC 2/2] iio: ina2xx: convert AVERGING ratio setting from generic sysfs attr to ABI Marc Titinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447757050-4214-2-git-send-email-mtitinger@baylibre.com \
--to=mtitinger@baylibre.com \
--cc=daniel.baluta@intel.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-api@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).