From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Mladek Subject: [PATCH v3 06/22] kthread: Add destroy_kthread_worker() Date: Wed, 18 Nov 2015 14:25:11 +0100 Message-ID: <1447853127-3461-7-git-send-email-pmladek@suse.com> References: <1447853127-3461-1-git-send-email-pmladek@suse.com> Return-path: In-Reply-To: <1447853127-3461-1-git-send-email-pmladek@suse.com> Sender: owner-linux-mm@kvack.org To: Andrew Morton , Oleg Nesterov , Tejun Heo , Ingo Molnar , Peter Zijlstra Cc: Steven Rostedt , "Paul E. McKenney" , Josh Triplett , Thomas Gleixner , Linus Torvalds , Jiri Kosina , Borislav Petkov , Michal Hocko , linux-mm@kvack.org, Vlastimil Babka , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Petr Mladek List-Id: linux-api@vger.kernel.org The current kthread worker users call flush() and stop() explicitly. This function drains the worker, stops it, and frees the kthread_worker struct in one call. It is supposed to be used together with create_kthread_worker*() that allocates struct kthread_worker. Also note that drain() correctly handles self-queuing works in compare with flush(). Signed-off-by: Petr Mladek --- include/linux/kthread.h | 2 ++ kernel/kthread.c | 21 +++++++++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/include/linux/kthread.h b/include/linux/kthread.h index 943900c7ce35..c4a95a3ba500 100644 --- a/include/linux/kthread.h +++ b/include/linux/kthread.h @@ -136,4 +136,6 @@ bool queue_kthread_work(struct kthread_worker *worker, void flush_kthread_work(struct kthread_work *work); void flush_kthread_worker(struct kthread_worker *worker); +void destroy_kthread_worker(struct kthread_worker *worker); + #endif /* _LINUX_KTHREAD_H */ diff --git a/kernel/kthread.c b/kernel/kthread.c index a18ad3b58f61..1d41e0faef2d 100644 --- a/kernel/kthread.c +++ b/kernel/kthread.c @@ -838,3 +838,24 @@ void drain_kthread_worker(struct kthread_worker *worker) spin_unlock_irq(&worker->lock); } EXPORT_SYMBOL(drain_kthread_worker); + +/** + * destroy_kthread_worker - destroy a kthread worker + * @worker: worker to be destroyed + * + * Drain and destroy @worker. It has the same conditions + * for use as drain_kthread_worker(), see above. + */ +void destroy_kthread_worker(struct kthread_worker *worker) +{ + struct task_struct *task; + + task = worker->task; + if (WARN_ON(!task)) + return; + + drain_kthread_worker(worker); + kthread_stop(task); + kfree(worker); +} +EXPORT_SYMBOL(destroy_kthread_worker); -- 1.8.5.6 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org