From: David Decotigny <ddecotig@gmail.com>
To: "David S. Miller" <davem@davemloft.net>,
Ben Hutchings <ben@decadent.org.uk>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-api@vger.kernel.org, linux-mips@linux-mips.org,
fcoe-devel@open-fcoe.org,
Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>
Cc: Eric Dumazet <edumazet@google.com>,
Eugenia Emantayev <eugenia@mellanox.co.il>,
Or Gerlitz <ogerlitz@mellanox.com>,
Ido Shamay <idos@mellanox.com>, Joe Perches <joe@perches.com>,
Saeed Mahameed <saeedm@mellanox.com>,
Govindarajulu Varadarajan <_govind@gmx.com>,
Venkata Duvvuru <VenkatKumar.Duvvuru@Emulex.Com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Pravin B Shelar <pshelar@nicira.com>,
Ed Swierk <eswierk@skyportsystems.com>,
Robert Love <robert.w.love@intel.com>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
Yuval Mintz <Yuval.Mintz@qlogic.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
David Decotigny <decot@googlers.com>
Subject: [PATCH net-next v4 08/19] net: bonding: use __ethtool_get_ksettings
Date: Wed, 9 Dec 2015 09:59:18 -0800 [thread overview]
Message-ID: <1449683969-7305-9-git-send-email-ddecotig@gmail.com> (raw)
In-Reply-To: <1449683969-7305-1-git-send-email-ddecotig@gmail.com>
From: David Decotigny <decot@googlers.com>
Signed-off-by: David Decotigny <decot@googlers.com>
---
drivers/net/bonding/bond_main.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index fe0e7a6..ce8c026 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -374,22 +374,20 @@ down:
static void bond_update_speed_duplex(struct slave *slave)
{
struct net_device *slave_dev = slave->dev;
- struct ethtool_cmd ecmd;
- u32 slave_speed;
+ struct ethtool_ksettings ecmd;
int res;
slave->speed = SPEED_UNKNOWN;
slave->duplex = DUPLEX_UNKNOWN;
- res = __ethtool_get_settings(slave_dev, &ecmd);
+ res = __ethtool_get_ksettings(slave_dev, &ecmd);
if (res < 0)
return;
- slave_speed = ethtool_cmd_speed(&ecmd);
- if (slave_speed == 0 || slave_speed == ((__u32) -1))
+ if (ecmd.parent.speed == 0 || ecmd.parent.speed == ((__u32)-1))
return;
- switch (ecmd.duplex) {
+ switch (ecmd.parent.duplex) {
case DUPLEX_FULL:
case DUPLEX_HALF:
break;
@@ -397,8 +395,8 @@ static void bond_update_speed_duplex(struct slave *slave)
return;
}
- slave->speed = slave_speed;
- slave->duplex = ecmd.duplex;
+ slave->speed = ecmd.parent.speed;
+ slave->duplex = ecmd.parent.duplex;
return;
}
--
2.6.0.rc2.230.g3dd15c0
next prev parent reply other threads:[~2015-12-09 17:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 17:59 [PATCH net-next v4 00/19] RFC: new ETHTOOL_GSETTINGS/SSETTINGS API David Decotigny
2015-12-09 17:59 ` [PATCH net-next v4 01/19] lib/bitmap.c: conversion routines to/from u32 array David Decotigny
2015-12-09 17:59 ` [PATCH net-next v4 02/19] test_bitmap: unit tests for lib/bitmap.c David Decotigny
2015-12-09 17:59 ` [PATCH net-next v4 03/19] net: usnic: remove unused call to ethtool_ops::get_settings David Decotigny
2015-12-09 17:59 ` [PATCH net-next v4 04/19] net: usnic: use __ethtool_get_settings David Decotigny
2015-12-09 17:59 ` [PATCH net-next v4 05/19] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API David Decotigny
2015-12-09 17:59 ` [PATCH net-next v4 06/19] tx4939: use __ethtool_get_ksettings David Decotigny
2015-12-09 17:59 ` [PATCH net-next v4 07/19] net: usnic: " David Decotigny
2015-12-09 17:59 ` David Decotigny [this message]
2015-12-09 17:59 ` [PATCH net-next v4 09/19] net: ipvlan: " David Decotigny
2015-12-09 17:59 ` [PATCH net-next v4 10/19] net: macvlan: " David Decotigny
2015-12-09 17:59 ` [PATCH net-next v4 11/19] net: team: " David Decotigny
2015-12-09 17:59 ` [PATCH net-next v4 12/19] net: fcoe: " David Decotigny
2015-12-09 19:18 ` kbuild test robot
2015-12-10 4:01 ` David Decotigny
2015-12-09 17:59 ` [PATCH net-next v4 13/19] net: rdma: " David Decotigny
2015-12-09 17:59 ` [PATCH net-next v4 14/19] net: 8021q: " David Decotigny
2015-12-09 17:59 ` [PATCH net-next v4 15/19] net: bridge: " David Decotigny
2015-12-09 17:59 ` [PATCH net-next v4 16/19] net: core: " David Decotigny
2015-12-09 17:59 ` [PATCH net-next v4 17/19] net: ethtool: remove unused __ethtool_get_settings David Decotigny
2015-12-09 17:59 ` [PATCH net-next v4 18/19] net: mlx4: convenience predicate for debug messages David Decotigny
2015-12-09 17:59 ` [PATCH net-next v4 19/19] net: mlx4: use new ETHTOOL_G/SSETTINGS API David Decotigny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449683969-7305-9-git-send-email-ddecotig@gmail.com \
--to=ddecotig@gmail.com \
--cc=JBottomley@parallels.com \
--cc=VenkatKumar.Duvvuru@Emulex.Com \
--cc=Yuval.Mintz@qlogic.com \
--cc=_govind@gmx.com \
--cc=akpm@linux-foundation.org \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=decot@googlers.com \
--cc=edumazet@google.com \
--cc=eswierk@skyportsystems.com \
--cc=eugenia@mellanox.co.il \
--cc=fcoe-devel@open-fcoe.org \
--cc=idos@mellanox.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joe@perches.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux@rasmusvillemoes.dk \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=pshelar@nicira.com \
--cc=robert.w.love@intel.com \
--cc=saeedm@mellanox.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).