From: Chunyan Zhang <zhang.chunyan@linaro.org>
To: mathieu.poirier@linaro.org, alexander.shishkin@linux.intel.com
Cc: mike.leach@arm.com, Michael.Williams@arm.com, al.grant@arm.com,
tor@ti.com, nicolas.guion@st.com, pratikp@codeaurora.org,
zhang.lyra@gmail.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-api@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: [PATCH V5 0/4] Introduce CoreSight STM support
Date: Thu, 7 Apr 2016 10:51:15 +0800 [thread overview]
Message-ID: <1459997479-19431-1-git-send-email-zhang.chunyan@linaro.org> (raw)
This patchset adds support for the CoreSight STM IP block.
Changes from V4:
- Rebased the whole patch set onto [4] (v4.6-rc1).
- Made a few minor modifications according to the code changes since v4.5.
- Replaced the original 1/4 with a new patch the Alex provided.
- Another new patch 2/4 in this set is for storing path from CS-STM to sink.
- Addressed comments from V4.
- Removed coresight_simple_func() from CS-STM driver, used the common definition instead.
- Modified STM tracer-id from an arbitrary value 0x20 to 0x1.
- Replaced module_amba_driver() with builtin_amba_driver() according to [5].
- Used driver->suppress_bind_attr to prevent CS-STM being unbound from the driver.
- Updated the kernel version (4.7) and month in sysfs-bus-coresight-devices-stm.
- Replaced 'mshared' with 'hw_override' in CS-STM driver.
- Initialized sw_start and sw_end with 1.
- Returned a size of '1' after processing FLAG packets.
- Removed pre-compile option 'CONFIG_64BIT' for the packet size of 8.
- Added Michael Williams's Reviewed-by in 4/4.
Changes from V3:
- Removed ioctl get_options interface from the generic STM code and CoreSight STM driver.
- Removed 'write_max' from the structure 'stm_drvdata', and changed 'write_64bit' to 'write_bytes'.
- Revised stm_fundamental_data_size() to return the fundamental data size instead of 0/1.
- Removed stm_remove() from the driver.
- Revised the return value of ::packet() callback function according to [2].
- Modified stm_send() to send one STP packet at a time.
- Added comments to invariant/guaranteed CoreSight STM transaction mode.
Changes from V2:
- Changed to return -EFAULT if failed on the command STP_GET_OPTIONS.
- Used Alex's patch [1] instead of the last 2/6.
- Removed the while loop from stm_send(), since the packet size passed
to it isn't larger than 4 bytes on 32-bit system and 8 bytes on
64-bit system.
- Removed stm_send_64bit(), since the process of packets on 64-bit
CS-STM should be basically the same with on 32-bit system, except the
maximum length of writing STM at a time.
- Removed the support of writing 64-bit to CoreSight STM buffer at a time
on 32-bit ARM architecture according to an ARM engineer suggestion. As
he said that the STM might receive a 64-bit write, or might receive a
pair of 32-bit writes to the two addressed words in either order.
So 64-bit write isn't guaranteed to work on the ARM 32-bit architecture.
Changes from v1:
- Added a definition of coresight_simple_func() in CS-STM driver to
avoid the kbuild test robot error for the time being. This
modification will be removed when merging the code in which the
coresight_simple_func() has been moved to the header file.
- Calculate the channel number according to the channel memory space size.
Thanks,
Chunyan
[1] https://lkml.org/lkml/2016/2/4/652
[2] https://lkml.org/lkml/2016/2/12/397
[3] https://lkml.org/lkml/2015/12/22/348
[4] https://git.linaro.org/kernel/coresight.git/shortlog/refs/heads/next
[5] http://www.spinics.net/lists/kernel/msg2187320.html
Alexander Shishkin (1):
stm class: Support devices that override software assigned masters
Mathieu Poirier (2):
coresight: adding path for STM device
coresight-stm: Bindings for System Trace Macrocell
Pratik Patel (1):
coresight-stm: adding driver for CoreSight STM component
.../ABI/testing/sysfs-bus-coresight-devices-stm | 53 ++
Documentation/ABI/testing/sysfs-class-stm | 10 +
.../devicetree/bindings/arm/coresight.txt | 28 +
Documentation/trace/coresight.txt | 37 +-
drivers/hwtracing/coresight/Kconfig | 11 +
drivers/hwtracing/coresight/Makefile | 1 +
drivers/hwtracing/coresight/coresight-stm.c | 918 +++++++++++++++++++++
drivers/hwtracing/coresight/coresight.c | 106 ++-
drivers/hwtracing/stm/core.c | 15 +
include/linux/coresight-stm.h | 6 +
include/linux/stm.h | 3 +
include/uapi/linux/coresight-stm.h | 21 +
12 files changed, 1183 insertions(+), 26 deletions(-)
create mode 100644 Documentation/ABI/testing/sysfs-bus-coresight-devices-stm
create mode 100644 drivers/hwtracing/coresight/coresight-stm.c
create mode 100644 include/linux/coresight-stm.h
create mode 100644 include/uapi/linux/coresight-stm.h
--
1.9.1
next reply other threads:[~2016-04-07 2:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 2:51 Chunyan Zhang [this message]
2016-04-07 2:51 ` [PATCH V5 1/4] stm class: Support devices that override software assigned masters Chunyan Zhang
2016-04-07 2:51 ` [PATCH V5 2/4] coresight: adding path for STM device Chunyan Zhang
2016-04-07 2:51 ` [PATCH V5 3/4] coresight-stm: Bindings for System Trace Macrocell Chunyan Zhang
2016-04-07 2:51 ` [PATCH V5 4/4] coresight-stm: adding driver for CoreSight STM component Chunyan Zhang
2016-04-20 15:06 ` [PATCH V5 0/4] Introduce CoreSight STM support Mathieu Poirier
2016-04-20 17:08 ` Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459997479-19431-1-git-send-email-zhang.chunyan@linaro.org \
--to=zhang.chunyan@linaro.org \
--cc=Michael.Williams@arm.com \
--cc=al.grant@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@arm.com \
--cc=nicolas.guion@st.com \
--cc=pratikp@codeaurora.org \
--cc=tor@ti.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).