linux-api.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Richard W.M. Jones" <rjones@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	akpm@linux-foundation.org, luto@kernel.org,
	viro@zeniv.linux.org.uk, mathieu.desnoyers@efficios.com,
	zab@redhat.com, emunson@akamai.com, paulmck@linux.vnet.ibm.com,
	aarcange@redhat.com, josh@joshtriplett.org, xemul@parallels.com,
	sfr@canb.auug.org.au, milosz@adfin.com, rostedt@goodmis.org,
	arnd@arndb.de, ebiederm@xmission.com, gorcunov@openvz.org,
	iulia.manda21@gmail.com, dave.hansen@linux.intel.com,
	mguzik@redhat.com, adobriyan@gmail.com, dave@stgolabs.net,
	linux-api@vger.kernel.org, gorcunov@gmail.com, fw@deneb.enyo.de
Subject: [PATCH v3 0/2] vfs: Define new syscall getumask.
Date: Wed, 13 Apr 2016 14:57:55 +0100	[thread overview]
Message-ID: <1460555877-12950-1-git-send-email-rjones@redhat.com> (raw)

v2 -> v3:

 - Add the syscall to uapi/asm-generic/unistd.h.

 - Retest.

----------------------------------------------------------------------

It's not possible to read the process umask without also modifying it,
which is what umask(2) does.  A library cannot read umask safely,
especially if the main program might be multithreaded.

This patch series adds a trivial system call "getumask" which returns
the umask of the current process.

Another approach to this has been attempted before, adding something
to /proc, although it didn't go anywhere.  See:

  http://comments.gmane.org/gmane.linux.kernel/1292109

Another way to solve this would be to add a thread-safe getumask to
glibc.  Since glibc could own the mutex, this would permit libraries
linked to this glibc to read umask safely.

I should also note that man-pages documents getumask(3), but no
version of glibc has ever implemented it.

Typical test script:

#include <stdio.h>
#include <stdlib.h>
#include <linux/unistd.h>
#include <sys/syscall.h>

int main(int argc, char *argv[])
{
  int r = syscall(329);
  if (r == -1) {
    perror("getumask");
    exit(1);
  }
  printf("umask = %o\n", r);
  exit(0);
}

$ ./getumask 
umask = 22

Rich.

             reply	other threads:[~2016-04-13 13:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13 13:57 Richard W.M. Jones [this message]
2016-04-13 13:57 ` [PATCH v3 1/2] vfs: Define new syscall getumask Richard W.M. Jones
2016-04-13 13:57 ` [PATCH v3 2/2] x86: Wire up new getumask system call on x86 Richard W.M. Jones
     [not found] ` <1460555877-12950-1-git-send-email-rjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-04-13 14:18   ` [PATCH v3 0/2] vfs: Define new syscall getumask Cyrill Gorcunov
2016-04-13 18:52   ` Davidlohr Bueso
2016-04-13 19:06     ` Richard W.M. Jones
     [not found]       ` <20160413190609.GL11600-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-04-13 19:12         ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1460555877-12950-1-git-send-email-rjones@redhat.com \
    --to=rjones@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=dave@stgolabs.net \
    --cc=ebiederm@xmission.com \
    --cc=emunson@akamai.com \
    --cc=fw@deneb.enyo.de \
    --cc=gorcunov@gmail.com \
    --cc=gorcunov@openvz.org \
    --cc=hpa@zytor.com \
    --cc=iulia.manda21@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mguzik@redhat.com \
    --cc=milosz@adfin.com \
    --cc=mingo@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=rostedt@goodmis.org \
    --cc=sfr@canb.auug.org.au \
    --cc=tglx@linutronix.de \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xemul@parallels.com \
    --cc=zab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).