From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mathieu Desnoyers Subject: Re: [RFC PATCH 3/9] arm64: allocate sys_membarrier system call number Date: Thu, 3 Sep 2015 15:38:58 +0000 (UTC) Message-ID: <1476370440.35879.1441294738582.JavaMail.zimbra@efficios.com> References: <1440698215-8355-1-git-send-email-mathieu.desnoyers@efficios.com> <1440698215-8355-4-git-send-email-mathieu.desnoyers@efficios.com> <20150902101049.GE25720@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150902101049.GE25720-5wv7dgnIgG8@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Will Deacon Cc: Andrew Morton , linux-api , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Catalin Marinas List-Id: linux-api@vger.kernel.org ----- On Sep 2, 2015, at 6:10 AM, Will Deacon will.deacon-5wv7dgnIgG8@public.gmane.org wrote: > On Thu, Aug 27, 2015 at 06:56:49PM +0100, Mathieu Desnoyers wrote: >> arm64 sys_membarrier number is already wired for arm64 through >> asm-generic/unistd.h, but needs to be allocated separately for >> the 32-bit compability layer of arm64. >> >> [ Untested on this architecture. To try it out: fetch linux-next/akpm, >> apply this patch, build/run a membarrier-enabled kernel, and do make >> kselftest. ] >> >> Signed-off-by: Mathieu Desnoyers >> CC: Andrew Morton >> CC: linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> CC: Catalin Marinas >> CC: Will Deacon >> --- >> arch/arm64/include/asm/unistd32.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm64/include/asm/unistd32.h >> b/arch/arm64/include/asm/unistd32.h >> index cef934a..d97be80 100644 >> --- a/arch/arm64/include/asm/unistd32.h >> +++ b/arch/arm64/include/asm/unistd32.h >> @@ -797,3 +797,5 @@ __SYSCALL(__NR_memfd_create, sys_memfd_create) >> __SYSCALL(__NR_bpf, sys_bpf) >> #define __NR_execveat 387 >> __SYSCALL(__NR_execveat, compat_sys_execveat) >> +#define __NR_membarrier 388 >> +__SYSCALL(__NR_membarrier, sys_membarrier) > > I think people have made similar comments for other architectures, but > please also updated __NR_compat_syscalls when adding new compat syscalls > here. Thanks for pointing it out! I'm fixing it for the next RFC round. Mathieu > > Will -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com