linux-api.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Xu (Hello71)" <alex_y_xu@yahoo.ca>
To: Christian Brauner <brauner@kernel.org>, Aleksa Sarai <cyphar@cyphar.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Shuah Khan <shuah@kernel.org>, Jeff Xu <jeffxu@google.com>,
	Kees Cook <keescook@chromium.org>,
	Daniel Verkamp <dverkamp@chromium.org>,
	Dominique Martinet <asmadeus@codewreck.org>,
	stable@vger.kernel.org, linux-api@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-kselftest@vger.kernel.org
Subject: Don't fill the kernel log with memfd_create messages
Date: Wed, 30 Aug 2023 11:52:33 -0400	[thread overview]
Message-ID: <1693408388.rwssx8r1h9.none@localhost> (raw)
In-Reply-To: 1693408388.rwssx8r1h9.none.ref@localhost

Hi all,

Recently "memfd: improve userspace warnings for missing exec-related 
flags" was merged. On my system, this is a regression, not an 
improvement, because the entire 256k kernel log buffer (default on x86) 
is filled with these warnings and "__do_sys_memfd_create: 122 callbacks 
suppressed". I haven't investigated too closely, but the most likely 
cause is Wayland libraries.

This is too serious of a consequence for using an old API, especially 
considering how recently the flags were added. The vast majority of 
software has not had time to add the flags: glibc does not define the 
macros until 2.38 which was released less than one month ago, man-pages 
does not document the flags, and according to Debian Code Search, only 
systemd, stress-ng, and strace actually pass either of these flags.

Furthermore, since old kernels reject unknown flags, it's not just a 
matter of defining and passing the flag; every program needs to 
add logic to handle EINVAL and try again.

Some other way needs to be found to encourage userspace to add the 
flags; otherwise, this message will be patched out because the kernel 
log becomes unusable after running unupdated programs, which will still 
exist even after upstreams are fixed. In particular, AppImages, 
flatpaks, snaps, and similar app bundles contain vendored Wayland 
libraries which can be difficult or impossible to update.

Thanks,
Alex.

       reply	other threads:[~2023-08-30 18:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1693408388.rwssx8r1h9.none.ref@localhost>
2023-08-30 15:52 ` Alex Xu (Hello71) [this message]
2023-09-04 13:31   ` Don't fill the kernel log with memfd_create messages Vlastimil Babka
2023-09-05 12:10     ` Linux regression tracking #update (Thorsten Leemhuis)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1693408388.rwssx8r1h9.none@localhost \
    --to=alex_y_xu@yahoo.ca \
    --cc=akpm@linux-foundation.org \
    --cc=asmadeus@codewreck.org \
    --cc=brauner@kernel.org \
    --cc=cyphar@cyphar.com \
    --cc=dverkamp@chromium.org \
    --cc=jeffxu@google.com \
    --cc=keescook@chromium.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=shuah@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).