From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79B5416EB45 for ; Thu, 11 Jul 2024 19:18:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720725492; cv=none; b=oEeMc9hvfIAqQ0KUF8C/rZFsqJgd8U+tLHyXnmdVY5J7mtBADZBqCuYbxdYpO1CMAGCpkGc/hnX6bHFIDokYYrOABjBbwzzYZroLUaD3M4eMaLaFypGVse0Mn4CU3EBQkeESRdxWoLMl1gJbJK9zKz3c3fi+EbbzLrqpkmiiN4U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720725492; c=relaxed/simple; bh=LD5F8waAmDcJ+gfEOAlGZEOJ5gl2yhVpWvogsEeiWJQ=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=LTMWzEIxSJ5ZD14QX7PuMaX9IdAzibc0cRp5zuFU50+TVpp4CUu/s6tGWQ35z8dPwjtNmBUscySpsDn/Jp9HODKYeWYBkjsKkU9zdqwCdXvYFlM8LnGXfcXWqSY0lkLtLPigKYXv+nFfvpqmEQ+p0Db9GA9fTCoEorb5aDjxjPs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DkPNt9fO; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DkPNt9fO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720725488; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BsFK6AFfUoEsMQwEYVBX+EezO+YNFPKdzylcEdBJ5wQ=; b=DkPNt9fOECB/YWo9FXplbKl0FvMZ2NLwBsv1rzzqCGdPT09YZNuXJxWsheD+6jJTqX9b73 Heaym1wT0q1ezddjlP3IlDOE0bA/igMvE+Fx/2C1hn6jPNYaCTH5GTE6Acs2EocIy1nGNb B6wNNKqaNvuJX6A2mXyXoyL8Pkb0z5o= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-103-rJBuE9umMMqFhRdlzZh1Yw-1; Thu, 11 Jul 2024 15:18:07 -0400 X-MC-Unique: rJBuE9umMMqFhRdlzZh1Yw-1 Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-649731dd35bso1058261a12.0 for ; Thu, 11 Jul 2024 12:18:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720725486; x=1721330286; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BsFK6AFfUoEsMQwEYVBX+EezO+YNFPKdzylcEdBJ5wQ=; b=EkuG234VdpEIL2r0BFbd10XhuOxTj3JG4CezVZrR1v4sxqcVaaIdvXGG7y7H8FqLM3 IqXHVW3QAL7bMANvLI3AhEAGD1ljsDHnPdXDxXHJ5kN4FhCqrM9W10xxz65G42hF344B 5ZNOc3sNesE0vZm0C3nyWiwjLOP3Nh8SaoDumNa7SgkfpYkpKLnI4XKDZh6071wEjWqt ntJ2lRoITXctVpkMgN5JVlD2OTKZP5ZZD1NoHadfDU2x6z6p6pCJw/LtITV6hoiYK27h YU9Gtuc4rA+cKlTCQNjIFBOZrHoDssgeS34568Y6IKff+USyY7uTsEtjE1aZhT1oSDVS qZhQ== X-Forwarded-Encrypted: i=1; AJvYcCV+VGhLs3tCQ58tEXWIlsLNqqX/O6j5wyt+SrUXH8wekpdANqqmE7huZPse6fw3R8lR2lSDsBhqdI6mCWkcpAdwZRVcJzJOYhCR X-Gm-Message-State: AOJu0YxAFwdtqgWV0cl7KUqZsufgFruLn3y5bzBdbkPiwR1Ws0Uhj/aE ncRwoUStOm3Ki7nYtbQlUDffNJdOj7IUSSxP9JPEeWY+yMec6cNnhUi2HMLzZnEHGy8nGWvbTd4 Yas/v88n+U99OO7ypMCv2pZMQwbJmHKxP2oyaApnXklmTlkdrvSvcd+tuOw== X-Received: by 2002:a05:6a20:db0c:b0:1c0:f1a8:d9da with SMTP id adf61e73a8af0-1c29822d487mr8813943637.21.1720725486032; Thu, 11 Jul 2024 12:18:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGD/IxMxt6B0he3UDBu2rDg+SCwJWefFoWRmvGoNS9xSPNAQ/jnj1cb5nQDtVXdO8li+MEN0Q== X-Received: by 2002:a05:6a20:db0c:b0:1c0:f1a8:d9da with SMTP id adf61e73a8af0-1c29822d487mr8813922637.21.1720725485558; Thu, 11 Jul 2024 12:18:05 -0700 (PDT) Received: from [10.35.209.243] ([208.115.86.75]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70b438eb4eesm6213417b3a.93.2024.07.11.12.18.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jul 2024 12:18:05 -0700 (PDT) Message-ID: <1c8632b4-06a5-49da-be0c-6fc7ac2b3257@redhat.com> Date: Thu, 11 Jul 2024 21:18:03 +0200 Precedence: bulk X-Mailing-List: linux-api@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v22 1/4] mm: add MAP_DROPPABLE for designating always lazily freeable mappings From: David Hildenbrand To: "Jason A. Donenfeld" Cc: Linus Torvalds , linux-kernel@vger.kernel.org, patches@lists.linux.dev, tglx@linutronix.de, linux-crypto@vger.kernel.org, linux-api@vger.kernel.org, x86@kernel.org, Greg Kroah-Hartman , Adhemerval Zanella Netto , Carlos O'Donell , Florian Weimer , Arnd Bergmann , Jann Horn , Christian Brauner , David Hildenbrand , linux-mm@kvack.org, Yu Zhao References: <98798483-dfcd-451e-94bb-57d830bf68d8@redhat.com> <54b6de32-f127-4928-9f4a-acb8653e5c81@redhat.com> <8586b19c-2e14-4164-888f-8c3b86f3f963@redhat.com> <443146f4-9db8-4a19-91f1-b6822fad8ce8@redhat.com> Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <443146f4-9db8-4a19-91f1-b6822fad8ce8@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11.07.24 20:56, David Hildenbrand wrote: > On 11.07.24 20:54, Jason A. Donenfeld wrote: >> On Thu, Jul 11, 2024 at 08:24:07PM +0200, David Hildenbrand wrote: >>>> And PG_large_rmappable seems to only be used for hugetlb branches. >>> >>> It should be set for THP/large folios. >> >> And it's tested too, apparently. >> >> Okay, well, how disappointing is this below? Because I'm running out of >> tricks for flag reuse. >> >> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h >> index b9e914e1face..c1ea49a7f198 100644 >> --- a/include/linux/page-flags.h >> +++ b/include/linux/page-flags.h >> @@ -110,6 +110,7 @@ enum pageflags { >> PG_workingset, >> PG_error, >> PG_owner_priv_1, /* Owner use. If pagecache, fs may use*/ >> + PG_owner_priv_2, > > Oh no, no new page flags please :) > > Maybe just follow what Linux suggested: pass vma to pte_dirty() and > always return false for these special VMAs. ... or look into removing that one case that gives us headake. No idea what would happen if we do the following: CCing Yu Zhao. diff --git a/mm/vmscan.c b/mm/vmscan.c index 0761f91b407f..d1dfbd4fd38d 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -4280,14 +4280,9 @@ static bool sort_folio(struct lruvec *lruvec, struct folio *folio, struct scan_c return true; } - /* dirty lazyfree */ - if (type == LRU_GEN_FILE && folio_test_anon(folio) && folio_test_dirty(folio)) { - success = lru_gen_del_folio(lruvec, folio, true); - VM_WARN_ON_ONCE_FOLIO(!success, folio); - folio_set_swapbacked(folio); - lruvec_add_folio_tail(lruvec, folio); - return true; - } + /* lazyfree: we may not be allowed to set swapbacked: MAP_DROPPABLE */ + if (type == LRU_GEN_FILE && folio_test_anon(folio) && folio_test_dirty(folio)) + return false; -- Cheers, David / dhildenb