linux-api.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Evgeniy Polyakov <zbr-i6C2adt8DTjR7s880joybQ@public.gmane.org>
To: Robert Love <rlove-L7G0xEPcOZbYtjvyW6yDsg@public.gmane.org>
Cc: John McCutchan <ttb-/fF4VJJ1vBJctGpslLZhzA@public.gmane.org>,
	linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	Andrew Morton
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Subject: [take 2] Use pid in inotify events.
Date: Mon, 10 Nov 2008 18:13:45 +0300	[thread overview]
Message-ID: <20081110151345.GA15796@ioremap.net> (raw)
In-Reply-To: <acdcfe7e0811081035l56eedf05x8b3b7ee2fc01eee6-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hi.

This patch allows to send IO origin PID in inotify events (using cookie
fields for all events except moving, where it is already used to track
move from and move to parts) when its uid matches inotify owner uid or
when inotify owner has admin capabilities (Jeff Schroeder's idea).

Signed-off-by: Evgeniy Polyakov <zbr-i6C2adt8DTjR7s880joybQ@public.gmane.org>

diff --git a/fs/inotify.c b/fs/inotify.c
index 690e725..835259d 100644
--- a/fs/inotify.c
+++ b/fs/inotify.c
@@ -69,6 +69,9 @@ static atomic_t inotify_cookie;
  * inotify_add_watch() to the final put_inotify_watch().
  */
 
+#define IH_FLAGS_ADMIN		(0x00000001)
+/* handler owner has admin capabilities */
+
 /*
  * struct inotify_handle - represents an inotify instance
  *
@@ -80,6 +83,8 @@ struct inotify_handle {
 	struct list_head	watches;	/* list of watches */
 	atomic_t		count;		/* reference count */
 	u32			last_wd;	/* the last wd allocated */
+	uid_t			uid;		/* owner's uid */
+	u32			flags;		/* operation flags */
 	const struct inotify_operations *in_ops; /* inotify caller operations */
 };
 
@@ -292,6 +297,11 @@ void inotify_inode_queue_event(struct inode *inode, u32 mask, u32 cookie,
 			mutex_lock(&ih->mutex);
 			if (watch_mask & IN_ONESHOT)
 				remove_watch_no_event(watch, ih);
+
+			if (!cookie && ((ih->flags & IH_FLAGS_ADMIN) ||
+					(current->uid == ih->uid)))
+				cookie = task_tgid_vnr(current);
+
 			ih->in_ops->handle_event(watch, watch->wd, mask, cookie,
 						 name, n_inode);
 			mutex_unlock(&ih->mutex);
@@ -459,6 +469,10 @@ struct inotify_handle *inotify_init(const struct inotify_operations *ops)
 	mutex_init(&ih->mutex);
 	ih->last_wd = 0;
 	ih->in_ops = ops;
+	ih->uid = current->user->uid;
+	ih->flags = 0;
+	if (capable(CAP_SYS_ADMIN))
+		ih->flags |= IH_FLAGS_ADMIN;
 	atomic_set(&ih->count, 0);
 	get_inotify_handle(ih);
 
-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2008-11-10 15:13 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <acdcfe7e0811081035l56eedf05x8b3b7ee2fc01eee6@mail.gmail.com>
     [not found] ` <acdcfe7e0811081035l56eedf05x8b3b7ee2fc01eee6-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-08 18:40   ` [1/1] Use pid in inotify events Evgeniy Polyakov
     [not found]     ` <20081108184013.GA11888-i6C2adt8DTjR7s880joybQ@public.gmane.org>
2008-11-08 22:03       ` Evgeniy Polyakov
2008-11-10 15:13   ` Evgeniy Polyakov [this message]
2008-11-16 23:24   ` [take 3] " Evgeniy Polyakov
     [not found]     ` <20081116232450.GA13547-i6C2adt8DTjR7s880joybQ@public.gmane.org>
2008-11-17 16:59       ` Michael Kerrisk
     [not found]         ` <cfd18e0f0811170859w1d3f903ej1d5626f2d2bf4496-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-17 17:15           ` Evgeniy Polyakov
     [not found]             ` <20081117171508.GA564-i6C2adt8DTjR7s880joybQ@public.gmane.org>
2008-11-17 17:23               ` Michael Kerrisk
     [not found]                 ` <cfd18e0f0811170923q6b72bd0fn9d319bbceb8fa6a-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-17 17:52                   ` Evgeniy Polyakov
     [not found]                     ` <20081117175212.GA2224-i6C2adt8DTjR7s880joybQ@public.gmane.org>
2008-11-20 13:09                       ` Pavel Machek
     [not found]                         ` <20081120130902.GA1408-+ZI9xUNit7I@public.gmane.org>
2008-11-21 14:03                           ` Evgeniy Polyakov
     [not found]                             ` <20081121140325.GA12384-i6C2adt8DTjR7s880joybQ@public.gmane.org>
2008-11-21 14:20                               ` Michael Kerrisk
     [not found]                                 ` <517f3f820811210620o34307610hf926bbe3b3828e8c-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-21 14:37                                   ` Evgeniy Polyakov
2008-11-21 14:30                               ` Robert Love
     [not found]                                 ` <acdcfe7e0811210630s65404ef5pf2b94731c2a872e1-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-21 14:53                                   ` Evgeniy Polyakov
2008-11-21 14:57                                   ` Pavel Machek
     [not found]                                     ` <20081121145709.GC1554-+ZI9xUNit7I@public.gmane.org>
2008-11-21 15:08                                       ` Evgeniy Polyakov
2008-11-18 13:19           ` Christoph Hellwig
     [not found]             ` <20081118131937.GC16944-jcswGhMUV9g@public.gmane.org>
2008-11-19 14:05               ` Evgeniy Polyakov
     [not found]                 ` <cfd18e0f0811190634g276b4a2dm5b3d5de25a5c9222@mail.gmail.com>
     [not found]                   ` <cfd18e0f0811190634g276b4a2dm5b3d5de25a5c9222-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-19 14:43                     ` Michael Kerrisk
2008-11-19 14:53                     ` Evgeniy Polyakov
     [not found]                       ` <20081119145351.GA2652-i6C2adt8DTjR7s880joybQ@public.gmane.org>
2008-11-20 22:34                         ` John McCutchan
     [not found]                           ` <cfec22b10811201434v2230d11dvc9797018e433fd20-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-20 23:06                             ` Evgeniy Polyakov
     [not found]                               ` <20081120230612.GB6536-i6C2adt8DTjR7s880joybQ@public.gmane.org>
2008-11-21 18:39                                 ` Arnd Bergmann
2008-11-22  7:12                                   ` David Newall
     [not found]                                     ` <4927B0D5.4020907-KzQzY1MbaKjAHznzqCTclw@public.gmane.org>
2008-11-22  9:41                                       ` Evgeniy Polyakov
     [not found]                                         ` <20081122094144.GB12543-i6C2adt8DTjR7s880joybQ@public.gmane.org>
2008-11-22 11:41                                           ` David Newall
     [not found]                                   ` <200811211939.46812.arnd-r2nGTMty4D4@public.gmane.org>
2008-11-22  9:37                                     ` Evgeniy Polyakov
     [not found]                                       ` <20081122093749.GA12543-i6C2adt8DTjR7s880joybQ@public.gmane.org>
2008-11-24  5:08                                         ` John McCutchan
     [not found]                                           ` <cfec22b10811232108u3ade8b66w58999054c03549fc-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-24  7:30                                             ` Evgeniy Polyakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081110151345.GA15796@ioremap.net \
    --to=zbr-i6c2adt8dtjr7s880joybq@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=rlove-L7G0xEPcOZbYtjvyW6yDsg@public.gmane.org \
    --cc=ttb-/fF4VJJ1vBJctGpslLZhzA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).