From mboxrd@z Thu Jan 1 00:00:00 1970 From: Evgeniy Polyakov Subject: Re: [take2] Inotify: nested attributes support. Date: Wed, 26 Nov 2008 10:42:39 +0300 Message-ID: <20081126074239.GA17525@ioremap.net> References: <20081125194234.GA24449@ioremap.net> <20081125162434.4feacbbf.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20081125162434.4feacbbf.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andrew Morton Cc: john-jueV0HHMeujJJrXXpGQQMAC/G2K4zDHf@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, hch-jcswGhMUV9g@public.gmane.org, rlove-L7G0xEPcOZbYtjvyW6yDsg@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, pavel-AlSwsSmVLrQ@public.gmane.org, davidn-KzQzY1MbaKjAHznzqCTclw@public.gmane.org, Eric Paris List-Id: linux-api@vger.kernel.org Hi Andrew. On Tue, Nov 25, 2008 at 04:24:34PM -0800, Andrew Morton (akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org) wrote: > I guess I'm being more than usually thick, but I don't understand what > this is all about, why it was implemented, what value it provides to > users, etc, etc? Why do I want scalable nested attributes in inotify?? Originally I just wanted to have a PID value in the inotify events, so reused cookie for that, but people rather vocally rised against this. So solution is to extend its structure. It would be possible just to add couple more bytes and store data there, but if we will want to add some more data into event later, we will have to implement inotify3 and so on. So I implemented a way to put essentially any number of new and old events in any order, turn then on and off, and do not care about possible limitation of the structure. As example I added PID, TID, write IO start/size and name attributes. > I'm buried in patches which I don't understand lately, and having > hundreds of people send patches at one guy who doesn't understand them > isn't a good system. Eric Paris is working on inotify-type things as > well. It would be neat if you guys were to understand and review each > other's work. Please. No problem, I will review patches if added to the copy. I'm not subscsribed to linux-kernel@ so will miss them otherwise. -- Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html