From: Nathan Lynch <ntl@pobox.com>
To: Oren Laadan <orenl@cs.columbia.edu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@osdl.org>,
containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-api@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Serge Hallyn <serue@us.ibm.com>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Mike Waychison <mikew@google.com>
Subject: Re: [RFC v12][PATCH 13/14] Checkpoint multiple processes
Date: Mon, 12 Jan 2009 17:14:52 -0600 [thread overview]
Message-ID: <20090112231452.GC6850@localdomain> (raw)
In-Reply-To: <1230542187-10434-14-git-send-email-orenl@cs.columbia.edu>
> +/* count number of tasks in tree (and optionally fill pid's in array) */
> +static int cr_tree_count_tasks(struct cr_ctx *ctx)
> +{
> + struct task_struct *root = ctx->root_task;
> + struct task_struct *task = root;
> + struct task_struct *parent = NULL;
> + struct task_struct **tasks_arr = ctx->tasks_arr;
> + int tasks_nr = ctx->tasks_nr;
> + int nr = 0;
> +
> + read_lock(&tasklist_lock);
> +
> + /* count tasks via DFS scan of the tree */
> + while (1) {
> + if (tasks_arr) {
> + /* unlikely, but ... */
> + if (nr == tasks_nr)
> + return -EBUSY; /* cleanup in cr_ctx_free() */
Returns without unlocking tasklist_lock?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-01-12 23:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 9:16 [RFC v12][PATCH 00/14] Kernel based checkpoint/restart Oren Laadan
2008-12-29 9:16 ` [RFC v12][PATCH 02/14] Checkpoint/restart: initial documentation Oren Laadan
2008-12-29 9:16 ` [RFC v12][PATCH 03/14] Make file_pos_read/write() public Oren Laadan
2008-12-29 9:16 ` [RFC v12][PATCH 04/14] General infrastructure for checkpoint restart Oren Laadan
2008-12-29 9:16 ` [RFC v12][PATCH 05/14] x86 support for checkpoint/restart Oren Laadan
2008-12-29 9:16 ` [RFC v12][PATCH 06/14] Dump memory address space Oren Laadan
2008-12-29 9:16 ` [RFC v12][PATCH 07/14] Restore " Oren Laadan
2008-12-29 9:16 ` [RFC v12][PATCH 08/14] Infrastructure for shared objects Oren Laadan
2008-12-29 9:16 ` [RFC v12][PATCH 09/14] Dump open file descriptors Oren Laadan
[not found] ` <1230542187-10434-1-git-send-email-orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2008-12-29 9:16 ` [RFC v12][PATCH 01/14] Create syscalls: sys_checkpoint, sys_restart Oren Laadan
[not found] ` <1230542187-10434-2-git-send-email-orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-01-14 18:04 ` Balbir Singh
2009-01-14 22:31 ` Oren Laadan
2008-12-29 9:16 ` [RFC v12][PATCH 10/14] Restore open file descriprtors Oren Laadan
2008-12-29 9:16 ` [RFC v12][PATCH 11/14] External checkpoint of a task other than ourself Oren Laadan
2009-01-06 20:05 ` [RFC v12][PATCH 00/14] Kernel based checkpoint/restart Dave Hansen
2009-01-06 20:23 ` Andrew Morton
2008-12-29 9:16 ` [RFC v12][PATCH 12/14] Track in-kernel when we expect checkpoint/restart to work Oren Laadan
2008-12-29 9:16 ` [RFC v12][PATCH 13/14] Checkpoint multiple processes Oren Laadan
2009-01-12 23:14 ` Nathan Lynch [this message]
2009-01-14 17:27 ` Oren Laadan
2008-12-29 9:16 ` [RFC v12][PATCH 14/14] Restart " Oren Laadan
2009-01-04 20:19 ` Serge E. Hallyn
2009-01-07 3:20 ` Oren Laadan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090112231452.GC6850@localdomain \
--to=ntl@pobox.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mikew@google.com \
--cc=mingo@elte.hu \
--cc=orenl@cs.columbia.edu \
--cc=serue@us.ibm.com \
--cc=tglx@linutronix.de \
--cc=torvalds@osdl.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).