From: Arnd Bergmann <arnd@arndb.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-api@vger.kernel.org, aarcange@redhat.com,
Ulrich Drepper <drepper@redhat.com>
Subject: Re: [PATCH v6 0/5] Add preadv & pwritev system calls.
Date: Fri, 16 Jan 2009 18:52:04 +0100 [thread overview]
Message-ID: <200901161852.04953.arnd@arndb.de> (raw)
In-Reply-To: <1232124344-25892-1-git-send-email-kraxel@redhat.com>
On Friday 16 January 2009, Gerd Hoffmann wrote:
> Next round of the preadv & pwritev patch series. Had no review comments
> to fix. That means it is ready to be merged, right?
In general, getting no feedback does not mean something's ready ;-)
Your patches look pretty polished though, and IIRC the only
real objection was to whether or not the syscalls should be
there in the first place. Did you get any feedback from Ulrich
Drepper as to whether he plans to add support to glibc?
> Changes:
> - compat_sys_{read,write}v bugfix patch dropped (merged).
> - rebase to latest git, adapt to CVE-2009-0029 changes.
>
> How to proceed now? Is there a syscall maintainer where I could queue
> up the patches? If not, anyone (akpm?) willng to pick this up? Should
> I try to send to Linus directly?
>
> What is the usual way to handle the arch-specific syscall windup? I'd
> prefer to leave that to the arch maintainers as they know best what
> needs to be done, is that ok? Right now only x86 (/me) and mips (patch
> from Ralf Baechle) is covered ...
I'd say get it into linux-next as a git tree, then let the arch maintainers
send you the missing patches to hook up the syscalls so that it can go
in as one chunk.
Have you done the glibc patch already? You probably also need to provide
an alternative user space implementation based on a pread/pwrite loop for
older kernels.
Arnd <><
next prev parent reply other threads:[~2009-01-16 17:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-16 16:45 [PATCH v6 0/5] Add preadv & pwritev system calls Gerd Hoffmann
2009-01-16 16:45 ` [PATCH 1/5] create compat_readv() Gerd Hoffmann
2009-01-16 16:45 ` [PATCH 2/5] create compat_writev() Gerd Hoffmann
2009-01-16 17:28 ` Arnd Bergmann
2009-01-16 16:45 ` [PATCH 3/5] Add preadv and pwritev system calls Gerd Hoffmann
2009-01-16 17:34 ` Arnd Bergmann
2009-01-16 16:45 ` [PATCH 4/5] MIPS: Add preadv(2) and pwritev(2) syscalls Gerd Hoffmann
[not found] ` <1232124344-25892-1-git-send-email-kraxel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-01-16 16:45 ` [PATCH 5/5] switch compat readv/preadv/writev/pwritev from fget to fget_light Gerd Hoffmann
2009-01-16 16:53 ` [PATCH v6 0/5] Add preadv & pwritev system calls Michael Kerrisk
2009-01-16 17:52 ` Arnd Bergmann [this message]
2009-01-16 19:20 ` Ulrich Drepper
2009-01-19 14:20 ` Gerd Hoffmann
2009-01-21 0:11 ` Petr Baudis
2009-01-21 9:31 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901161852.04953.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=aarcange@redhat.com \
--cc=drepper@redhat.com \
--cc=kraxel@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).