From: Jonathan Corbet <corbet-T1hC0tSOHrs@public.gmane.org>
Cc: Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
andi-Vw/NltI1exuRpAAqCnN02g@public.gmane.org,
viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org,
oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org
Subject: Re: [PATCH, RFC] Remove fasync() BKL usage, take 3325
Date: Thu, 22 Jan 2009 23:01:45 -0700 [thread overview]
Message-ID: <20090122230145.7e434dee@tpl> (raw)
In-Reply-To: <20090123055404.GL15750-qrUzlfsMFqo/4alezvVtWx2eb7JE58TQ@public.gmane.org>
On Fri, 23 Jan 2009 06:54:04 +0100
Andi Kleen <andi-Vw/NltI1exuRpAAqCnN02g@public.gmane.org> wrote:
> The state needs to be protected while the per driver ->fasync callback
> runs, otherwise the bit can get out of sync with what the driver
> thinks it is.
>
> Mind you imho the best way would be to move the bit manipulation for
> that into the drivers, but that would require to change them all.
You know, I'm not sure why I didn't look into that. Do we want drivers
reaching directly into struct file and making changes? Maybe a helper
would be better. Hmm, maybe we could call it fasync_helper() and it
could just do the right thing? Will investigate further...
jon
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-01-23 6:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-15 22:32 [PATCH, RFC] Remove fasync() BKL usage, take 3325 Jonathan Corbet
[not found] ` <20090115153211.663df310-vw3g6Xz/EtPk1uMJSBkQmQ@public.gmane.org>
2009-01-22 14:51 ` Andrew Morton
[not found] ` <20090122065104.2787df2d.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-01-22 16:09 ` Andi Kleen
[not found] ` <20090122160935.GI15750-qrUzlfsMFqo/4alezvVtWx2eb7JE58TQ@public.gmane.org>
2009-01-23 5:21 ` Jonathan Corbet
2009-01-22 20:32 ` Christoph Hellwig
[not found] ` <20090122203248.GA20159-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2009-01-23 4:56 ` Andi Kleen
[not found] ` <20090123045646.GK15750-qrUzlfsMFqo/4alezvVtWx2eb7JE58TQ@public.gmane.org>
2009-01-28 0:53 ` Andrew Morton
2009-01-28 0:55 ` Andrew Morton
[not found] ` <20090127165504.53ed7a2d.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-01-28 3:14 ` Oleg Nesterov
[not found] ` <20090128031439.GA11025-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-01-28 3:57 ` Jonathan Corbet
[not found] ` <20090127205739.1384343f-vw3g6Xz/EtPk1uMJSBkQmQ@public.gmane.org>
2009-01-28 4:23 ` Oleg Nesterov
[not found] ` <20090128042337.GA15060-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-01-28 14:13 ` Jonathan Corbet
2009-01-28 17:36 ` Christoph Hellwig
[not found] ` <20090128173618.GA3174-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2009-01-28 17:44 ` Jonathan Corbet
[not found] ` <20090128104414.09aee3f9-vw3g6Xz/EtPk1uMJSBkQmQ@public.gmane.org>
2009-01-28 17:55 ` Christoph Hellwig
[not found] ` <20090128175541.GA7074-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2009-01-28 18:13 ` Matt Mackall
2009-01-28 21:05 ` Jonathan Corbet
2009-01-28 18:14 ` David Daney
2009-01-29 14:37 ` Andi Kleen
2009-01-23 5:15 ` Jonathan Corbet
2009-01-23 5:31 ` Andrew Morton
[not found] ` <20090122213105.74142908.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-01-23 5:45 ` Matt Mackall
2009-01-23 6:15 ` Andi Kleen
2009-01-23 10:45 ` Bernd Petrovitsch
2009-01-23 5:54 ` Andi Kleen
[not found] ` <20090123055404.GL15750-qrUzlfsMFqo/4alezvVtWx2eb7JE58TQ@public.gmane.org>
2009-01-23 6:01 ` Jonathan Corbet [this message]
2009-01-23 6:57 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090122230145.7e434dee@tpl \
--to=corbet-t1hc0tsohrs@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org \
--cc=andi-Vw/NltI1exuRpAAqCnN02g@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).