From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleg Nesterov Subject: Re: [PATCH, RFC] Remove fasync() BKL usage, take 3325 Date: Wed, 28 Jan 2009 05:23:37 +0100 Message-ID: <20090128042337.GA15060@redhat.com> References: <20090115153211.663df310@bike.lwn.net> <20090122065104.2787df2d.akpm@linux-foundation.org> <20090122203248.GA20159@infradead.org> <20090123045646.GK15750@one.firstfloor.org> <20090127165504.53ed7a2d.akpm@linux-foundation.org> <20090128031439.GA11025@redhat.com> <20090127205739.1384343f@bike.lwn.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20090127205739.1384343f-vw3g6Xz/EtPk1uMJSBkQmQ@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jonathan Corbet Cc: Andrew Morton , Andi Kleen , hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org List-Id: linux-api@vger.kernel.org On 01/27, Jonathan Corbet wrote: > > On Wed, 28 Jan 2009 04:14:39 +0100 > Oleg Nesterov wrote: > > > I'll try to make the patch tomorrow, but the problem is that I am not > > sure this is not too ugly. > > FWIW, I'm partway through a new attempt using bitops for f_flags, moving > FASYNC flag handling into fasync_helper(), and doing away with > additional locks altogether. I have to get past the publication > deadline before I can finish it, though. Great. I'd be happy to agree with another approach. But please don't forget it is not strictly necessary f_op->fasync() must use fasync_helper(). And we have users (pipe_rdwr_fasync) which call fasync_helper() twice. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html