From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Helsley Subject: Re: [RFC][v8][PATCH 9/10]: Define clone3() syscall Date: Thu, 22 Oct 2009 06:57:22 -0700 Message-ID: <20091022135722.GH7757@count0.beaverton.ibm.com> References: <20091016180631.GA31036@us.ibm.com> <20091019174405.GE27627@count0.beaverton.ibm.com> <4ADCDAA8.5080408@zytor.com> <20091019235012.GF27627@count0.beaverton.ibm.com> <4ADF06B7.50508@zytor.com> <4AE0444B.5070603@zytor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Cc: "H. Peter Anvin" , Matt Helsley , Sukadev Bhattiprolu , randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, Containers , Nathan Lynch , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Louis.Rilling-aw0BnHfMbSpBDgjK7y7TUQ@public.gmane.org, "Eric W. Biederman" , kosaki.motohiro-+CUm20s59erQFUHtdCDX3A@public.gmane.org, mingo-X9Un+BFzKDI@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, Alexey Dobriyan , roland-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Pavel Emelyanov List-Id: linux-api@vger.kernel.org On Thu, Oct 22, 2009 at 02:14:16PM +0200, Michael Kerrisk wrote: > Peter, > > On Thu, Oct 22, 2009 at 1:38 PM, H. Peter Anvin wrote: > > On 10/22/2009 07:26 PM, Michael Kerrisk wrote: > >>> > >>> "3" is number of arguments. > >> > >> sys_clone3(struct clone_struct __user *ucs, pid_t __user *pids) > >> > >> It appears to me that the number of arguments is 2. > >> > > > > It was 3 at one point... I'm not sure when that changed last :-/ > > > >>> It's better than "extended" or something like > >>> that simply because "extended" just means "more than", and a number at > >>> least > >>> tells you *how much more than*. > >> > >> I'm not sure why you think including a number in the name tells us > >> "how much more than". Unless you are considering the numbering to be > >> version numbers, which apparently is not what you mean. > > > > It is a version number of sorts. > > So, sometimes, a number in a system call should be the bit width of > some arguments(s), sometimes it should be the number of arguments, and > sometimes (well, just occasionally, as in mmap2() and clone()) -- it > should be a version number? Does the weather play any part in the In this case 3 could be both the number of arguments and the version number (clone, clone2, clone3). Match 2 conventions with one choice of name. :) Cheers, -Matt Helsley