From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Rothwell Subject: Re: F_SETOWN_EX and F_GETLK64 conflict Date: Fri, 30 Oct 2009 16:13:20 +1100 Message-ID: <20091030161320.17d07dc9.sfr@canb.auug.org.au> References: <1254691822.21044.9.camel@laptop> Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA1"; boundary="Signature=_Fri__30_Oct_2009_16_13_20_+1100_D3NqZ+.Fp_O8cjYi" Return-path: In-Reply-To: <1254691822.21044.9.camel@laptop> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter Zijlstra Cc: "Joseph S. Myers" , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lkml , Oleg Nesterov , Stephane Eranian , Michael Kerrisk , Roland McGrath , Al Viro , Christoph Hellwig , Andrew Morton , Ingo Molnar List-Id: linux-api@vger.kernel.org --Signature=_Fri__30_Oct_2009_16_13_20_+1100_D3NqZ+.Fp_O8cjYi Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Peter, On Sun, 04 Oct 2009 23:30:22 +0200 Peter Zijlstra = wrote: > > On Sun, 2009-10-04 at 12:35 +0000, Joseph S. Myers wrote: > > In asm-generic/fcntl.h, F_SETOWN_EX and F_GETLK64 both have value 12, a= nd=20 > > F_GETOWN_EX and F_SETLK64 both have value 13. I don't see how this is= =20 > > going to work correctly. See=20 > > . >=20 >=20 > Ugh,.. yeah, non obvious collision that. This is why we have F_LINUX_SPECIFIC_BASE and use it in include/linux/fcntl.h ... it should be used as a base for any new fcntl types since they don't require backward compatibility. --=20 Cheers, Stephen Rothwell sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org http://www.canb.auug.org.au/~sfr/ --Signature=_Fri__30_Oct_2009_16_13_20_+1100_D3NqZ+.Fp_O8cjYi Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkrqdfAACgkQjjKRsyhoI8wR6ACdEKs7znjR8nNcvA2ZaCLZNR0c wmYAoI3XL92cSFc3MHyMDgsUo/nfpcEa =813U -----END PGP SIGNATURE----- --Signature=_Fri__30_Oct_2009_16_13_20_+1100_D3NqZ+.Fp_O8cjYi--