linux-api.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: Andrew Morton <akpm-3NddpPZAyC0@public.gmane.org>,
	Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>,
	serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org,
	"Eric W. Biederman"
	<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>,
	Alexey Dobriyan
	<adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Pavel Emelyanov <xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>,
	hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org,
	Nathan Lynch <nathanl-V7BBcbaFuwjMbYB6QlFGEg@public.gmane.org>,
	matthltc-npbjlsIvGkV82hYKe6nXyg@public.gmane.org,
	roland-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	mtk.manpages-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org,
	linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Containers
	<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
Subject: Re: [v12][PATCH 0/9] Implement eclone() syscall
Date: Thu, 19 Nov 2009 15:56:44 -0800	[thread overview]
Message-ID: <20091119235644.GA18720@us.ibm.com> (raw)
In-Reply-To: <200911191520.46445.arnd-r2nGTMty4D4@public.gmane.org>

Arnd Bergmann [arnd-r2nGTMty4D4@public.gmane.org] wrote:
| On Wednesday 11 November 2009, Sukadev Bhattiprolu wrote:
| > Based on these requirements and constraints, we explored a couple of system
| > call interfaces (in earlier versions of this patchset). Based on input from
| > Arnd Bergmann and others, the new interface of the system call is: 
| > 
| >         struct clone_args {
| >                 u64 clone_flags_high;
| >                 u64 child_stack_base;
| >                 u64 child_stack_size;
| >                 u64 parent_tid_ptr;
| >                 u64 child_tid_ptr;
| >                 u32 nr_pids;
| >                 u32 reserved0;
| >                 u64 reserved1;
| >         };
| > 
| >         sys_eclone(u32 flags_low, struct clone_args *cargs, int args_size,
| >                         pid_t *pids)
| 
| Sorry if I'm beating a dead horse here, but having three methods for
| possible extensions (flags, args_size and reserved fields) is going
| a bit too far, as I think we've discussed a few times before.

Based on earlier discussions, it looked like using 'flags' to extend
the number of arguments or size of clone_args was not clean. But I 
agree with your point on the redundancy.

How about dropping ->reserved1 and leaving the 'u32 reserved0' so the
structure size is same on all architectures ?

Sukadev

  parent reply	other threads:[~2009-11-19 23:56 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-11  4:34 [v12][PATCH 0/9] Implement eclone() syscall Sukadev Bhattiprolu
2009-11-11  4:42 ` [v12][PATCH 1/9] Factor out code to allocate pidmap page Sukadev Bhattiprolu
2009-11-11 22:38   ` Sukadev Bhattiprolu
2009-11-11  4:43 ` [v12][PATCH 2/9] Have alloc_pidmap() return actual error code Sukadev Bhattiprolu
2009-11-11 22:39   ` Sukadev Bhattiprolu
2009-11-11  4:43 ` [v12][PATCH 3/9] Define set_pidmap() function Sukadev Bhattiprolu
2009-11-11 22:39   ` Sukadev Bhattiprolu
2009-11-11  4:43 ` [v12][PATCH 4/9] Add target_pids parameter to alloc_pid() Sukadev Bhattiprolu
2009-11-11 22:39   ` Sukadev Bhattiprolu
2009-11-11  4:44 ` [v12][PATCH 5/9] Add target_pids parameter to copy_process() Sukadev Bhattiprolu
2009-11-11 22:40   ` Sukadev Bhattiprolu
2009-11-11  4:44 ` [v12][PATCH 6/9] Check invalid clone flags Sukadev Bhattiprolu
2009-11-11 22:40   ` Sukadev Bhattiprolu
2009-11-11  4:44 ` [v12][PATCH 7/9] Define do_fork_with_pids() Sukadev Bhattiprolu
2009-11-11 22:40   ` Sukadev Bhattiprolu
2009-11-11  4:45 ` [v12][PATCH 8/9] Define eclone() syscall Sukadev Bhattiprolu
2009-11-11 22:40   ` Sukadev Bhattiprolu
2009-11-11  4:45 ` [v12][PATCH 9/9] Document " Sukadev Bhattiprolu
2009-11-11 22:41   ` Sukadev Bhattiprolu
2009-11-11 22:38 ` [v12][PATCH 0/9] Implement " Sukadev Bhattiprolu
2009-11-19 14:20 ` Arnd Bergmann
     [not found]   ` <200911191520.46445.arnd-r2nGTMty4D4@public.gmane.org>
2009-11-19 23:56     ` Sukadev Bhattiprolu [this message]
     [not found]       ` <20091119235644.GA18720-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-11-20  8:08         ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091119235644.GA18720@us.ibm.com \
    --to=sukadev-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
    --cc=adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=akpm-3NddpPZAyC0@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
    --cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=matthltc-npbjlsIvGkV82hYKe6nXyg@public.gmane.org \
    --cc=mtk.manpages-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org \
    --cc=nathanl-V7BBcbaFuwjMbYB6QlFGEg@public.gmane.org \
    --cc=orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org \
    --cc=roland-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).