From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sukadev Bhattiprolu Subject: Re: [PATCH v21 011/100] eclone (11/11): Document sys_eclone Date: Wed, 5 May 2010 15:25:53 -0700 Message-ID: <20100505222553.GA6555@us.ibm.com> References: <1272723382-19470-1-git-send-email-orenl@cs.columbia.edu> <1272723382-19470-12-git-send-email-orenl@cs.columbia.edu> <20100505141447.fc2397f6.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20100505141447.fc2397f6.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Randy Dunlap Cc: Oren Laadan , Andrew Morton , containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Serge Hallyn , Matt Helsley , Pavel Emelyanov , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org List-Id: linux-api@vger.kernel.org Randy Dunlap [randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org] wrote: | > + base of the region allocated for stack. These architectures | > + must pass in the size of the stack-region in ->child_stack_size. | | stack region | | Seems unfortunate that different architectures use the fields differently. Yes and no. The field still has a single purpose, just that some architectures may not need it. We enforce that if unused on an architecture, the field must be 0. It looked like the easiest way to keep the API common across architectures. | | Is this example program meant to build only on i386? Yes. Will add a pointer to the clone*.[chS] and libeclone.a files in git://git.ncl.cs.columbia.edu/pub/git/user-cr.git for other architectures (currently x86_64, ppc, s390). Thanks for the review. Will fix the errors and repost. Sukadev