From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v2 12/23] netpoll: Introduce netpoll_target configs Date: Tue, 9 Nov 2010 09:27:13 -0800 Message-ID: <20101109172713.GA11073@kroah.com> References: <20101108203120.22479.19708.stgit@crlf.mtv.corp.google.com> <20101108203246.22479.60118.stgit@crlf.mtv.corp.google.com> <20101109033024.GA5220@cr0.nay.redhat.com> <20101109042732.GC5220@cr0.nay.redhat.com> <20101109090645.GG5220@cr0.nay.redhat.com> <20101109142053.GA3067@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mike Waychison Cc: Am??rico Wang , simon.kagstrom-vI6UBbBVNY+JA8cjQkG2/g@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org, Matt Mackall , adurbin-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, chavey-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-api@vger.kernel.org On Tue, Nov 09, 2010 at 09:24:33AM -0800, Mike Waychison wrote: > On Tue, Nov 9, 2010 at 6:20 AM, Greg KH wrote: > > On Tue, Nov 09, 2010 at 05:06:45PM +0800, Am??rico Wang wrote: > >> On Tue, Nov 09, 2010 at 12:34:24AM -0800, Mike Waychison wrote: > >> >On Mon, Nov 8, 2010 at 8:27 PM, Am??rico Wang wrote: > >> >> On Tue, Nov 09, 2010 at 11:30:24AM +0800, Am??rico Wang wrote: > >> >>> > >> >> .... > >> >>> > >> >>>So, either we need to de-modulize configfs or replace configfs = API > >> >>>with sysfs API. Personally, I prefer the former one, I don't th= ink > >> >>>configfs should be a module as long as it can provide API's > >> >>>for other subsystems, like debugfs. > >> >>> > >> >> > >> >> To clarify, I meant "as long as the API it provides can be used= by > >> >> other core subsystems". > >> >> > >> > > >> >Ya, I see the problem with it being a tristate. > >> > > >> >Why not just make netconsole support being compiled in force conf= igfs > >> >to be compiled in? =A0Or does that just set bad precedent? > >> > >> That is what netconsole does now, and this is fine, since netconso= le is > >> a module too, however, after you move that code into netpoll, then= netpoll > >> will have a dependence on it, we will have problems. > >> > >> I think we can let NETPOLL_TARGET depend on CONFIGFS_FS=3Dy, but I= still > >> see no reason why CONFIGFS_FS should be a module. > > > > No, just have the NETPOLL_TARGET set CONFIG_FS to y, don't force th= e > > code to always be that way if the user isn't going to want that opt= ion. >=20 > Can you clarify what you mean by "that way" here? I think I can't remember, as this is a bit complex. I'm just objecting to the changing of configfs to only be able to be built into the kernel. If this patch set requires configfs, great, the= n set the value to "Y", but don't change configfs like the proposed patch later in this email thread did. thanks, greg k-h