From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH V7 7/8] ptp: Added a clock driver for the IXP46x. Date: Sun, 2 Jan 2011 10:20:42 +0100 Message-ID: <20110102092042.GA14165@ucw.cz> References: <20110102084505.GA3980@ucw.cz> <20110102091233.GA2847@riccoc20.at.omicron.at> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20110102091233.GA2847-7KxsofuKt4IfAd9E5cN8NEzG7cXyKsk/@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Richard Cochran Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alan Cox , Arnd Bergmann , Christoph Lameter , David Miller , John Stultz , Krzysztof Halasa , Peter Zijlstra , Rodolfo Giometti , Thomas Gleixner List-Id: linux-api@vger.kernel.org On Sun 2011-01-02 10:12:33, Richard Cochran wrote: > On Sun, Jan 02, 2011 at 09:45:05AM +0100, Pavel Machek wrote: > > Hi!! > > > > > +struct ixp46x_channel_ctl { > > > + u32 Ch_Control; /* 0x40 Time Synchronization Channel Control */ > > > + u32 Ch_Event; /* 0x44 Time Synchronization Channel Event */ > > > + u32 TxSnapLo; /* 0x48 Transmit Snapshot Low Register */ > > > + u32 TxSnapHi; /* 0x4C Transmit Snapshot High Register */ > > > > CouldWeGetRidOfCamelCase? > > I agree that CamelCase is ugly and in bad taste. However, I make an > exception when the register level programmer's manual uses this style. > > IMHO, it is better to use the exact same mnemonics as in the > manual. That way, when the next person comes along to make a change to Given the comments -- does manual really use camelCase crap? And... the identifiers actually combine camelCase with _. Better fix it. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html