linux-api.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Andrew Morton <akpm@linux-foundation.org>, G@thunk.org
Cc: Indan Zupancic <indan@nul.nu>, Greg KH <greg@kroah.com>,
	Jonathan Nieder <jrnieder@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>, Sage Weil <sage@newdream.net>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>,
	linux-api@vger.kernel.org, mtk.manpages@gmail.com,
	viro@zeniv.linux.org.uk, hch@lst.de, l@jasper.es
Subject: Re: [PATCH v3] introduce sys_syncfs to sync a single file system
Date: Mon, 14 Mar 2011 17:11:19 -0400	[thread overview]
Message-ID: <20110314211119.GC8120@thunk.org> (raw)
In-Reply-To: <20110314131042.5a7fb32f.akpm@linux-foundation.org>

On Mon, Mar 14, 2011 at 01:10:42PM -0700, Andrew Morton wrote:
> 
> There might one day be a requirement to be able to initiate a
> resource-management-style writeback against a whole filesystem.  When
> that happens, we'll regret not having added a "mode" argument to
> sys_syncfs().

I'm a bit nervous about exposing WB_SYNC_NONE to userspace, because
its semantics are *definitely* hard to describe.  For example, at the
moment if you do a WB_SYNC_NONE writeback, the writeback code will
clamp the amount of data written back for each inode to
MAX_WRITEBACK_PAGES (1024) pages.  Do we want to document that?
Probably not!  But if we don't document it, what can userspace expect?

If you just issue a writeback_inodes_sb(), it's not the case that it
will start a process that will eventually write out everything (i.e.,
it's not the equivalent of a non-blocking data integrity sync).  It
just means, "write out some stuff".

I could imagine userspace wanting to start a non-blocking writeout of
all data blocking pages, and which doesn't cause queue flush / barrier
requests.  (i.e., a non-blocking-non-barrier-issuing-but-otherwise-a-
data-integrity writeback) But that's not something that the current
writeback machinery can do easily, at least not today.

It wouldn't hurt to have a "flags" field which we could expand later
--- but that can lead to portability headaches for userspace programs
that don't know whether a particular kernel is going to support a
particular flag or not.  So it's certainly not a panacea.

	   	   	    	 	       - Ted

  parent reply	other threads:[~2011-03-14 21:11 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.4.64.1102171035220.13904@cobra.newdream.net>
     [not found] ` <Pine.LNX.4.64.1102171035220.13904-vIokxiIdD2AQNTJnQDzGJqxOck334EZe@public.gmane.org>
2011-03-03  7:22   ` [RFC] introduce sys_syncat to sync a single file system Jonathan Nieder
2011-03-03  8:54     ` Aneesh Kumar K. V
     [not found]       ` <87bp1sziqn.fsf-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2011-03-07 23:17         ` [RFC] introduce sys_syncfs to sync a single file system (v2) Sage Weil
     [not found]           ` <Pine.LNX.4.64.1103071515070.11152-vIokxiIdD2AQNTJnQDzGJqxOck334EZe@public.gmane.org>
2011-03-08  5:27             ` Aneesh Kumar K. V
     [not found]               ` <8762ruchcr.fsf-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2011-03-10 14:56                 ` Arnd Bergmann
     [not found]                   ` <201103101556.44698.arnd-r2nGTMty4D4@public.gmane.org>
2011-03-10 19:28                     ` Sage Weil
2011-03-10 19:31           ` [PATCH v3] introduce sys_syncfs to sync a single file system Sage Weil
2011-03-10 22:08             ` Arnd Bergmann
     [not found]             ` <Pine.LNX.4.64.1103101125150.4190-vIokxiIdD2AQNTJnQDzGJqxOck334EZe@public.gmane.org>
2011-03-11  4:44               ` Aneesh Kumar K. V
2011-03-11 11:01             ` Indan Zupancic
     [not found]               ` <edfa4cf081249734807e582c14253fca.squirrel-2RFepEojUI3wYrDfM2ltn5vKXLoBo5SK@public.gmane.org>
2011-03-11 11:55                 ` Arnd Bergmann
     [not found]                   ` <201103111255.44979.arnd-r2nGTMty4D4@public.gmane.org>
2011-03-11 23:45                     ` Indan Zupancic
2011-03-11 23:56                       ` Jonathan Nieder
2011-03-12  1:53                         ` Indan Zupancic
     [not found]                           ` <9446ab1a2315c0d2476c30f8315a0503.squirrel-2RFepEojUI3wYrDfM2ltn5vKXLoBo5SK@public.gmane.org>
2011-03-12  2:10                             ` Jonathan Nieder
2011-03-12  4:22                               ` Indan Zupancic
2011-03-12 17:32                               ` Greg KH
     [not found]                                 ` <20110312173217.GA24981-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2011-03-14  1:56                                   ` Indan Zupancic
     [not found]                                     ` <1e597aedd3d7825dcc0630b1cf2399fa.squirrel-2RFepEojUI3wYrDfM2ltn5vKXLoBo5SK@public.gmane.org>
2011-03-14  4:29                                       ` Sage Weil
2011-03-14  9:27                                         ` Indan Zupancic
2011-03-14 10:22                                           ` Theodore Tso
     [not found]                                         ` <Pine.LNX.4.64.1103132114380.5145-vIokxiIdD2AQNTJnQDzGJqxOck334EZe@public.gmane.org>
2011-03-15 10:11                                           ` Dave Chinner
2011-03-15 13:00                                             ` Sage Weil
2011-03-15 15:56                                             ` Andreas Dilger
2011-03-15 16:08                                               ` Sage Weil
2011-03-15 20:18                                               ` Andrew Morton
2011-03-14 20:10                                       ` Andrew Morton
2011-03-14 20:29                                         ` Artem Bityutskiy
2011-03-14 21:11                                         ` Ted Ts'o [this message]
2011-03-14 21:20                                           ` Andrew Morton
     [not found]                                             ` <20110314142032.b9523309.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2011-03-14 23:17                                               ` Ted Ts'o
2011-03-14 21:22                                           ` Arnd Bergmann
2011-03-12  0:40                       ` Ric Wheeler
     [not found]                         ` <4D7AC0FE.8070806-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-03-12  1:33                           ` Indan Zupancic
     [not found]                             ` <1d4d1b7ae64da97f44cad0e2bda4f832.squirrel-2RFepEojUI3wYrDfM2ltn5vKXLoBo5SK@public.gmane.org>
2011-03-12  2:52                               ` Ric Wheeler
     [not found]                                 ` <4D7ADFDD.9080108-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-03-12  3:50                                   ` Indan Zupancic
2011-03-12 12:41                                     ` Ric Wheeler
     [not found]                                     ` <e118a1458c29e4f44bf71c7095e4bce8.squirrel-2RFepEojUI3wYrDfM2ltn5vKXLoBo5SK@public.gmane.org>
2011-03-12 18:31                                       ` Jeff Garzik
2011-03-14  1:31                                         ` Indan Zupancic
2011-03-14  1:37                                           ` Theodore Tso
2011-03-14  1:47                                             ` Indan Zupancic
2011-03-14  1:45                                           ` Jeff Garzik
     [not found]                                             ` <4D7D7325.2040708-o2qLIJkoznsdnm+yROfE0A@public.gmane.org>
2011-03-14  1:59                                               ` Indan Zupancic
2011-03-12 19:28                                       ` Artem Bityutskiy
2011-03-12 19:22                               ` Artem Bityutskiy
2011-03-14  1:38                                 ` Indan Zupancic
     [not found]                                   ` <3cc2c5c6fa6b3bd384017ae95a4241ab.squirrel-2RFepEojUI3wYrDfM2ltn5vKXLoBo5SK@public.gmane.org>
2011-03-14  5:52                                     ` Artem Bityutskiy
2011-03-13 20:59             ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110314211119.GC8120@thunk.org \
    --to=tytso@mit.edu \
    --cc=G@thunk.org \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=arnd@arndb.de \
    --cc=greg@kroah.com \
    --cc=hch@lst.de \
    --cc=indan@nul.nu \
    --cc=jrnieder@gmail.com \
    --cc=l@jasper.es \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=sage@newdream.net \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).