From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: uhid: broken interface: 32/64-bit compatibility Date: Mon, 18 Feb 2013 10:40:35 -0800 Message-ID: <20130218184035.GB15167@core.coreip.homeip.net> References: <20130215112911.68A98E0085@blue.fi.intel.com> <20130215120022.GA23694@x220> <20130215135141.1EFCEE0085@blue.fi.intel.com> <20130215200526.GA15811@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jiri Kosina Cc: "Kirill A. Shutemov" , Johan Hedberg , David Herrmann , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, RavindranathX Doddi , Greg Kroah-Hartman , Linus Torvalds , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Marcel Holtmann List-Id: linux-api@vger.kernel.org On Mon, Feb 18, 2013 at 11:28:40AM +0100, Jiri Kosina wrote: > On Fri, 15 Feb 2013, Dmitry Torokhov wrote: > > > > Here's my attempt to fix the issue. > > > > > > Not sure if tricks with padding in a good idea. We can just use __u64 > > > instead of pointer, but it will require update of userspace to silence > > > cast warning and will cause warning if you will try to use updated > > > userspace with old kernel headers. > > > > > > Any comments? > > > > This does not fix anything really, we simply have to deal with compat > > interface. > > > > Compiled but not tested. > > > > Thanks. > > Sorry for late response, I have been extremely busy doing some skiing :-) Sounds good. At least someone has the right priorities ;) -- Dmitry