Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

[Michael Kerrisk]

Vivek,

As per Documentation/SubmitChecklist , please CC linux-api@ on patces
that change the ABI/API. See
https://www.kernel.org/doc/man-pages/linux-api-ml.html.

Also, is there some draft man page for this new system call?

Thanks,

Michael

On Wed, Jun 4, 2014 at 7:50 PM, Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> On Wed, Jun 04, 2014 at 05:22:14PM +0800, WANG Chao wrote:
>
> [..]
>> > Index: kexec-tools/kexec/kexec.h
>> > ===================================================================
>> > --- kexec-tools.orig/kexec/kexec.h  2014-06-02 14:34:16.719774316 -0400
>> > +++ kexec-tools/kexec/kexec.h       2014-06-02 14:34:42.010036325 -0400
>> > @@ -156,6 +156,13 @@ struct kexec_info {
>> >     unsigned long kexec_flags;
>> >     unsigned long backup_src_start;
>> >     unsigned long backup_src_size;
>> > +   /* Set to 1 if we are using kexec2 syscall */
>> > +   unsigned long file_mode :1;
>> > +
>> > +   /* Filled by kernel image processing code */
>> > +   int initrd_fd;
>> > +   char *command_line;
>> > +   int command_line_len;
>> >  };
>> >
>> >  struct arch_map_entry {
>> > @@ -207,6 +214,7 @@ extern int file_types;
>> >  #define OPT_UNLOAD         'u'
>> >  #define OPT_TYPE           't'
>> >  #define OPT_PANIC          'p'
>> > +#define OPT_USE_KEXEC2_SYSCALL     's'
>> >  #define OPT_MEM_MIN             256
>> >  #define OPT_MEM_MAX             257
>> >  #define OPT_REUSE_INITRD   258
>> > @@ -230,6 +238,7 @@ extern int file_types;
>> >     { "mem-min",            1, 0, OPT_MEM_MIN }, \
>> >     { "mem-max",            1, 0, OPT_MEM_MAX }, \
>> >     { "reuseinitrd",        0, 0, OPT_REUSE_INITRD }, \
>> > +   { "use-kexec2-syscall", 0, 0, OPT_USE_KEXEC2_SYSCALL }, \
>> >     { "debug",              0, 0, OPT_DEBUG }, \
>> >
>> >  #define KEXEC_OPT_STR "h?vdfxluet:p"
>>
>> This line,
>> #define KEXEC_OPT_STR "h?vdfxluet:p"
>>
>> should be something like,
>> #define KEXEC_OPT_STR "h?vdfxluet:ps"
>
> Thanks chao. I will fix it.
>
> Thanks
> Vivek
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
Michael Kerrisk Linux man-pages maintainer;
http://www.kernel.org/doc/man-pages/
Author of "The Linux Programming Interface", http://blog.man7.org/

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

[Vivek Goyal]

On Wed, Jun 04, 2014 at 09:39:10PM +0200, Michael Kerrisk wrote:
> Vivek,
> 
> As per Documentation/SubmitChecklist , please CC linux-api@ on patces
> that change the ABI/API. See
> https://www.kernel.org/doc/man-pages/linux-api-ml.html.

Hi Michael,

Sorry, I did not notice that. I will CC linux-api@ in next version of
patches in patches which introduce new systemcal..

> 
> Also, is there some draft man page for this new system call?

No, there is none yet. In fact I don't see a man page for old kexec
system call either kexec_load().

Do you want me to write man page for this new syscall?

Thanks
Vivek

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

[Michael Kerrisk (man-pages)]

On 06/05/2014 04:04 PM, Vivek Goyal wrote:
> On Wed, Jun 04, 2014 at 09:39:10PM +0200, Michael Kerrisk wrote:
>> Vivek,
>>
>> As per Documentation/SubmitChecklist , please CC linux-api@ on patces
>> that change the ABI/API. See
>> https://www.kernel.org/doc/man-pages/linux-api-ml.html.
> 
> Hi Michael,
> 
> Sorry, I did not notice that. I will CC linux-api@ in next version of
> patches in patches which introduce new systemcal..
> 
>>
>> Also, is there some draft man page for this new system call?
> 
> No, there is none yet. In fact I don't see a man page for old kexec
> system call either kexec_load().

Is this not what you are meaning:
http://man7.org/linux/man-pages/man2/kexec_load.2.html
?
(It probably could be improved...)

> Do you want me to write man page for this new syscall?

These days, that's considered a desirable accompaniment to new 
syscall proposals.

Cheers,

Michael



-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

[Vivek Goyal]

On Fri, Jun 06, 2014 at 07:45:17AM +0200, Michael Kerrisk (man-pages) wrote:
> On 06/05/2014 04:04 PM, Vivek Goyal wrote:
> > On Wed, Jun 04, 2014 at 09:39:10PM +0200, Michael Kerrisk wrote:
> >> Vivek,
> >>
> >> As per Documentation/SubmitChecklist , please CC linux-api@ on patces
> >> that change the ABI/API. See
> >> https://www.kernel.org/doc/man-pages/linux-api-ml.html.
> > 
> > Hi Michael,
> > 
> > Sorry, I did not notice that. I will CC linux-api@ in next version of
> > patches in patches which introduce new systemcal..
> > 
> >>
> >> Also, is there some draft man page for this new system call?
> > 
> > No, there is none yet. In fact I don't see a man page for old kexec
> > system call either kexec_load().
> 
> Is this not what you are meaning:
> http://man7.org/linux/man-pages/man2/kexec_load.2.html
> ?
> (It probably could be improved...)

Yep. I missed it.

> 
> > Do you want me to write man page for this new syscall?
> 
> These days, that's considered a desirable accompaniment to new 
> syscall proposals.

Ok, I will write one for kexec_file_load() too. Or extend the existing
one to include both syscalls.

Thanks
Vivek