From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH v2 1/4] define PAGECACHE_TAG_* as enumeration under include/uapi Date: Fri, 4 Jul 2014 11:16:39 +1000 Message-ID: <20140704011639.GG9508@dastard> References: <1404424335-30128-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1404424335-30128-2-git-send-email-n-horiguchi@ah.jp.nec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1404424335-30128-2-git-send-email-n-horiguchi@ah.jp.nec.com> Sender: owner-linux-mm@kvack.org To: Naoya Horiguchi Cc: Andrew Morton , Konstantin Khlebnikov , Wu Fengguang , Arnaldo Carvalho de Melo , Borislav Petkov , "Kirill A. Shutemov" , Johannes Weiner , Rusty Russell , David Miller , Andres Freund , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Dave Hansen , Christoph Hellwig , Michael Kerrisk , Linux API , Naoya Horiguchi List-Id: linux-api@vger.kernel.org On Thu, Jul 03, 2014 at 05:52:12PM -0400, Naoya Horiguchi wrote: > We need the pagecache tags to be exported to userspace later in this > series for fincore(2), so this patch moves the definition to the new > include file for preparation. We also use the number of pagecache tags, > so this patch also adds it. > > Signed-off-by: Naoya Horiguchi NACK. The radix tree tags are deeply internal implementation details. They are an artifact of the current mark-and-sweep writeback algorithm, and as such should never, ever be exposed to userspace, let alone fixed in an ABI we need to support forever more. Cheers, Dave. -- Dave Chinner david@fromorbit.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org