From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleg Nesterov Subject: Re: [PATCH v10 0/11] seccomp: add thread sync ability Date: Fri, 11 Jul 2014 18:49:31 +0200 Message-ID: <20140711164931.GA18473@redhat.com> References: <1405017631-27346-1-git-send-email-keescook@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1405017631-27346-1-git-send-email-keescook@chromium.org> Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Kees Cook Cc: linux-kernel@vger.kernel.org, Andy Lutomirski , Alexei Starovoitov , "Michael Kerrisk (man-pages)" , Andrew Morton , Daniel Borkmann , Will Drewry , Julien Tinnes , David Drysdale , linux-api@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org, linux-arch@vger.kernel.org, linux-security-module@vger.kernel.org List-Id: linux-api@vger.kernel.org On 07/10, Kees Cook wrote: > > This adds the ability for threads to request seccomp filter > synchronization across their thread group (at filter attach time). > For example, for Chrome to make sure graphic driver threads are fully > confined after seccomp filters have been attached. > > To support this, locking on seccomp changes via thread-group-shared > sighand lock is introduced, along with refactoring of no_new_privs. Races > with thread creation are handled via delayed duplication of the seccomp > task struct field and cred_guard_mutex. > > This includes a new syscall (instead of adding a new prctl option), > as suggested by Andy Lutomirski and Michael Kerrisk. I do not not see any problems in this version, Reviewed-by: Oleg Nesterov