From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v2 2/5] mfd: max77693: Map charger device to its own of_node Date: Tue, 21 Oct 2014 11:17:05 +0100 Message-ID: <20141021101705.GF26842@x1> References: <1413808489-3524-1-git-send-email-k.kozlowski@samsung.com> <1413808489-3524-3-git-send-email-k.kozlowski@samsung.com> <20141020150630.GB26784@x1> <1413817781.11298.0.camel@AMDC1943> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1413817781.11298.0.camel@AMDC1943> Sender: linux-pm-owner@vger.kernel.org To: Krzysztof Kozlowski Cc: Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Samuel Ortiz , linux-api@vger.kernel.org, devicetree@vger.kernel.org, Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz List-Id: linux-api@vger.kernel.org On Mon, 20 Oct 2014, Krzysztof Kozlowski wrote: > On pon, 2014-10-20 at 16:06 +0100, Lee Jones wrote: > > On Mon, 20 Oct 2014, Krzysztof Kozlowski wrote: > >=20 > > > Add a "maxim,max77693-charger" of_compatible to the mfd_cell so t= he MFD > > > child device (the charger) will have its own of_node set. This wi= ll be > > > used by the max77693 charger driver in next patches to obtain bat= tery > > > configuration from DTS. > > >=20 > > > Signed-off-by: Krzysztof Kozlowski > > > --- > > > drivers/mfd/max77693.c | 5 ++++- > > > 1 file changed, 4 insertions(+), 1 deletion(-) > > >=20 > > > diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c > > > index cf008f45968c..2277a11b6629 100644 > > > --- a/drivers/mfd/max77693.c > > > +++ b/drivers/mfd/max77693.c > > > @@ -43,7 +43,10 @@ > > > =20 > > > static const struct mfd_cell max77693_devs[] =3D { > > > { .name =3D "max77693-pmic", }, > > > - { .name =3D "max77693-charger", }, > > > + { > > > + .name =3D "max77693-charger", > > > + .of_compatible =3D "maxim,max77693-charger", > > > + }, > > > { .name =3D "max77693-muic", }, > > > { .name =3D "max77693-haptic", }, > > > { > >=20 > > I'm guessing this can be applied separately? >=20 > Yes. Patch 3/5 also (it adds necessary defines and symbols for > chargers). I'll take this patch, but I think 3/5 is required by some of the other patches in the set, no? --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog