From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v1 1/3] tpm: merge duplicate transmit_cmd() functions Date: Wed, 22 Oct 2014 10:37:35 -0600 Message-ID: <20141022163735.GB12775@obsidianresearch.com> References: <1413995036-22497-1-git-send-email-jarkko.sakkinen@linux.intel.com> <1413995036-22497-2-git-send-email-jarkko.sakkinen@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1413995036-22497-2-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jarkko Sakkinen Cc: Peter Huewe , Ashley Lai , Marcel Selhorst , tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, josh.triplett-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, jason.gunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org List-Id: linux-api@vger.kernel.org On Wed, Oct 22, 2014 at 07:23:54PM +0300, Jarkko Sakkinen wrote: > Merged transmit_cmd() functions in tpm-interface.c and tpm-sysfs.c. > Added "tpm_" prefix for consistency sake. Changed cmd parameter as > opaque. This enables to use separate command structures for TPM1 > and TPM2 commands in future. Loose coupling works fine here. > > Signed-off-by: Jarkko Sakkinen Reviewed-By: Jason Gunthorpe Thanks Jarkko! Jason