From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH V4] kernel, add bug_on_warn Date: Tue, 28 Oct 2014 05:44:25 -0700 Message-ID: <20141028124425.GD3274@tassilo.jf.intel.com> References: <1414155207-29839-1-git-send-email-prarit@redhat.com> <20141028121636.GC3274@tassilo.jf.intel.com> <544F8A78.9070008@redhat.com> <20141028122900.GA10632@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20141028122900.GA10632@redhat.com> Sender: linux-doc-owner@vger.kernel.org To: Vivek Goyal Cc: Prarit Bhargava , linux-kernel@vger.kernel.org, Jonathan Corbet , Andrew Morton , Rusty Russell , "H. Peter Anvin" , Masami Hiramatsu , Fabian Frederick , isimatu.yasuaki@jp.fujitsu.com, linux-doc@vger.kernel.org, kexec@lists.infradead.org, linux-api@vger.kernel.org, jason.wessel@windriver.com List-Id: linux-api@vger.kernel.org > > I suppose ... but that would mean I would have to explain to an end user the > > elaborate process of enabling kdb, inserting a break point, etc. The whole > > purpose of this is to let an end user panic on WARN() easily. > > > > Asking an end user to enable kdb is magnitudes worse than asking them to > > recompile a kernel. > > Agreed. Asking a customer to setup and run kdb and put breakpoints is much > more pain than simply asking to reboot kernel with a command line option. If you have a command line option to execute kdb commands you still would only have a command line option, just a slightly longer one. kdb="on, bp warn_slowpath_common sr c, go" But it would be a generic facility instead of a special purpose hack. -Andi