From: Theodore Ts'o <tytso-3s7WtUTddSA@public.gmane.org>
To: Li Xi <pkuelelixi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
adilger-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org,
jack-AlSwsSmVLrQ@public.gmane.org,
viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org,
hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
dmonakhov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org
Subject: Re: [v6 2/4] ext4: adds project ID support
Date: Mon, 10 Nov 2014 23:26:06 -0500 [thread overview]
Message-ID: <20141111042606.GA17027@thunk.org> (raw)
In-Reply-To: <1415468619-31851-3-git-send-email-lixi-LfVdkaOWEx8@public.gmane.org>
On Sun, Nov 09, 2014 at 01:43:37AM +0800, Li Xi wrote:
> This patch adds a new internal field of ext4 inode to save project
> identifier. Also a new flag EXT4_INODE_PROJINHERIT is added for
> inheriting project ID from parent directory.
What would be the downside of simply always inhereiting the project ID
from the parent directory? I see that if the flag is not set, the
project id will be 0 instead. I'm not sure when that would actually
be desirable.
To the extent that the project ID is designed to implement a quota
over a directory extent, the fact that the owner can clear the
EXT4_PROJINHERET_FL and then arrange to have the quota charged to
project 0 seems to me to be a bug, not a feature.
Can you explain what your intended use case for this flag might be?
Thanks,
- Ted
next prev parent reply other threads:[~2014-11-11 4:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-08 17:43 [v6 0/4] ext4: add project quota support Li Xi
[not found] ` <1415468619-31851-1-git-send-email-lixi-LfVdkaOWEx8@public.gmane.org>
2014-11-08 17:43 ` [v6 1/4] vfs: adds general codes to enforces project quota limits Li Xi
[not found] ` <1415468619-31851-2-git-send-email-lixi-LfVdkaOWEx8@public.gmane.org>
2014-11-11 20:27 ` Jan Kara
2014-11-08 17:43 ` [v6 2/4] ext4: adds project ID support Li Xi
2014-11-10 22:21 ` Andreas Dilger
[not found] ` <1415468619-31851-3-git-send-email-lixi-LfVdkaOWEx8@public.gmane.org>
2014-11-11 4:26 ` Theodore Ts'o [this message]
2014-11-11 7:34 ` Li Xi
2014-11-11 20:23 ` Jan Kara
2014-11-11 20:31 ` Jan Kara
2014-11-08 17:43 ` [v6 3/4] ext4: adds project quota support Li Xi
[not found] ` <1415468619-31851-4-git-send-email-lixi-LfVdkaOWEx8@public.gmane.org>
2014-11-11 20:34 ` Jan Kara
2014-11-08 17:43 ` [v6 4/4] ext4: adds FS_IOC_FSSETXATTR/FS_IOC_FSGETXATTR interface support Li Xi
2014-11-10 0:05 ` Dave Chinner
2014-11-11 21:58 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141111042606.GA17027@thunk.org \
--to=tytso-3s7wtutddsa@public.gmane.org \
--cc=adilger-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org \
--cc=dmonakhov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
--cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=jack-AlSwsSmVLrQ@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pkuelelixi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).