* [PATCH] [media] Add RGB444_1X12 and RGB565_1X16 media bus formats
@ 2014-11-14 10:36 Boris Brezillon
[not found] ` <1415961360-14898-1-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Boris Brezillon @ 2014-11-14 10:36 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Hans Verkuil, Laurent Pinchart,
linux-media-u79uwXL29TY76Z2rM5mHXA
Cc: linux-api-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-doc-u79uwXL29TY76Z2rM5mHXA, Boris Brezillon
Add RGB444_1X12 and RGB565_1X16 format definitions and update the
documentation.
Signed-off-by: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Acked-by: Mauro Carvalho Chehab <mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
---
Documentation/DocBook/media/v4l/subdev-formats.xml | 40 ++++++++++++++++++++++
include/uapi/linux/media-bus-format.h | 4 ++-
2 files changed, 43 insertions(+), 1 deletion(-)
diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml b/Documentation/DocBook/media/v4l/subdev-formats.xml
index 18730b9..8c396db 100644
--- a/Documentation/DocBook/media/v4l/subdev-formats.xml
+++ b/Documentation/DocBook/media/v4l/subdev-formats.xml
@@ -563,6 +563,46 @@
<entry>b<subscript>1</subscript></entry>
<entry>b<subscript>0</subscript></entry>
</row>
+ <row id="MEDIA-BUS-FMT-RGB444-1X12">
+ <entry>MEDIA_BUS_FMT_RGB444_1X12</entry>
+ <entry>0x100d</entry>
+ <entry></entry>
+ &dash-ent-20;
+ <entry>r<subscript>3</subscript></entry>
+ <entry>r<subscript>2</subscript></entry>
+ <entry>r<subscript>1</subscript></entry>
+ <entry>r<subscript>0</subscript></entry>
+ <entry>g<subscript>3</subscript></entry>
+ <entry>g<subscript>2</subscript></entry>
+ <entry>g<subscript>1</subscript></entry>
+ <entry>g<subscript>0</subscript></entry>
+ <entry>b<subscript>3</subscript></entry>
+ <entry>b<subscript>2</subscript></entry>
+ <entry>b<subscript>1</subscript></entry>
+ <entry>b<subscript>0</subscript></entry>
+ </row>
+ <row id="MEDIA-BUS-FMT-RGB565-1X16">
+ <entry>MEDIA_BUS_FMT_RGB565_1X16</entry>
+ <entry>0x100d</entry>
+ <entry></entry>
+ &dash-ent-16;
+ <entry>r<subscript>4</subscript></entry>
+ <entry>r<subscript>3</subscript></entry>
+ <entry>r<subscript>2</subscript></entry>
+ <entry>r<subscript>1</subscript></entry>
+ <entry>r<subscript>0</subscript></entry>
+ <entry>g<subscript>5</subscript></entry>
+ <entry>g<subscript>4</subscript></entry>
+ <entry>g<subscript>3</subscript></entry>
+ <entry>g<subscript>2</subscript></entry>
+ <entry>g<subscript>1</subscript></entry>
+ <entry>g<subscript>0</subscript></entry>
+ <entry>b<subscript>4</subscript></entry>
+ <entry>b<subscript>3</subscript></entry>
+ <entry>b<subscript>2</subscript></entry>
+ <entry>b<subscript>1</subscript></entry>
+ <entry>b<subscript>0</subscript></entry>
+ </row>
</tbody>
</tgroup>
</table>
diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h
index 23b4090..cc7b79e 100644
--- a/include/uapi/linux/media-bus-format.h
+++ b/include/uapi/linux/media-bus-format.h
@@ -33,7 +33,7 @@
#define MEDIA_BUS_FMT_FIXED 0x0001
-/* RGB - next is 0x100e */
+/* RGB - next is 0x1010 */
#define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001
#define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002
#define MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE 0x1003
@@ -47,6 +47,8 @@
#define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b
#define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c
#define MEDIA_BUS_FMT_ARGB8888_1X32 0x100d
+#define MEDIA_BUS_FMT_RGB444_1X12 0x100e
+#define MEDIA_BUS_FMT_RGB565_1X16 0x100f
/* YUV (including grey) - next is 0x2024 */
#define MEDIA_BUS_FMT_Y8_1X8 0x2001
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread[parent not found: <1415961360-14898-1-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>]
* Re: [PATCH] [media] Add RGB444_1X12 and RGB565_1X16 media bus formats [not found] ` <1415961360-14898-1-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> @ 2014-11-14 13:58 ` Sakari Ailus 2014-11-14 15:04 ` Boris Brezillon 0 siblings, 1 reply; 5+ messages in thread From: Sakari Ailus @ 2014-11-14 13:58 UTC (permalink / raw) To: Boris Brezillon Cc: Mauro Carvalho Chehab, Hans Verkuil, Laurent Pinchart, linux-media-u79uwXL29TY76Z2rM5mHXA, linux-api-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-doc-u79uwXL29TY76Z2rM5mHXA Hi Boris, On Fri, Nov 14, 2014 at 11:36:00AM +0100, Boris Brezillon wrote: > Add RGB444_1X12 and RGB565_1X16 format definitions and update the > documentation. > > Signed-off-by: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> > Acked-by: Mauro Carvalho Chehab <mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> > --- > Documentation/DocBook/media/v4l/subdev-formats.xml | 40 ++++++++++++++++++++++ > include/uapi/linux/media-bus-format.h | 4 ++- > 2 files changed, 43 insertions(+), 1 deletion(-) > > diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml b/Documentation/DocBook/media/v4l/subdev-formats.xml > index 18730b9..8c396db 100644 > --- a/Documentation/DocBook/media/v4l/subdev-formats.xml > +++ b/Documentation/DocBook/media/v4l/subdev-formats.xml > @@ -563,6 +563,46 @@ > <entry>b<subscript>1</subscript></entry> > <entry>b<subscript>0</subscript></entry> > </row> > + <row id="MEDIA-BUS-FMT-RGB444-1X12"> > + <entry>MEDIA_BUS_FMT_RGB444_1X12</entry> > + <entry>0x100d</entry> > + <entry></entry> > + &dash-ent-20; > + <entry>r<subscript>3</subscript></entry> > + <entry>r<subscript>2</subscript></entry> > + <entry>r<subscript>1</subscript></entry> > + <entry>r<subscript>0</subscript></entry> > + <entry>g<subscript>3</subscript></entry> > + <entry>g<subscript>2</subscript></entry> > + <entry>g<subscript>1</subscript></entry> > + <entry>g<subscript>0</subscript></entry> > + <entry>b<subscript>3</subscript></entry> > + <entry>b<subscript>2</subscript></entry> > + <entry>b<subscript>1</subscript></entry> > + <entry>b<subscript>0</subscript></entry> > + </row> > + <row id="MEDIA-BUS-FMT-RGB565-1X16"> > + <entry>MEDIA_BUS_FMT_RGB565_1X16</entry> > + <entry>0x100d</entry> > + <entry></entry> > + &dash-ent-16; > + <entry>r<subscript>4</subscript></entry> > + <entry>r<subscript>3</subscript></entry> > + <entry>r<subscript>2</subscript></entry> > + <entry>r<subscript>1</subscript></entry> > + <entry>r<subscript>0</subscript></entry> > + <entry>g<subscript>5</subscript></entry> > + <entry>g<subscript>4</subscript></entry> > + <entry>g<subscript>3</subscript></entry> > + <entry>g<subscript>2</subscript></entry> > + <entry>g<subscript>1</subscript></entry> > + <entry>g<subscript>0</subscript></entry> > + <entry>b<subscript>4</subscript></entry> > + <entry>b<subscript>3</subscript></entry> > + <entry>b<subscript>2</subscript></entry> > + <entry>b<subscript>1</subscript></entry> > + <entry>b<subscript>0</subscript></entry> > + </row> > </tbody> > </tgroup> > </table> > diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h > index 23b4090..cc7b79e 100644 > --- a/include/uapi/linux/media-bus-format.h > +++ b/include/uapi/linux/media-bus-format.h > @@ -33,7 +33,7 @@ > > #define MEDIA_BUS_FMT_FIXED 0x0001 > > -/* RGB - next is 0x100e */ > +/* RGB - next is 0x1010 */ > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001 > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002 > #define MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE 0x1003 > @@ -47,6 +47,8 @@ > #define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b > #define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c > #define MEDIA_BUS_FMT_ARGB8888_1X32 0x100d > +#define MEDIA_BUS_FMT_RGB444_1X12 0x100e > +#define MEDIA_BUS_FMT_RGB565_1X16 0x100f I'd arrange these according to BPP and bits per sample, both in the header and documentation. > /* YUV (including grey) - next is 0x2024 */ > #define MEDIA_BUS_FMT_Y8_1X8 0x2001 -- Regards, Sakari Ailus e-mail: sakari.ailus-X3B1VOXEql0@public.gmane.org XMPP: sailus-PCDdDYkjdNMDXYZnReoRVg@public.gmane.org ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [media] Add RGB444_1X12 and RGB565_1X16 media bus formats 2014-11-14 13:58 ` Sakari Ailus @ 2014-11-14 15:04 ` Boris Brezillon 2014-11-15 14:49 ` Sakari Ailus 0 siblings, 1 reply; 5+ messages in thread From: Boris Brezillon @ 2014-11-14 15:04 UTC (permalink / raw) To: Sakari Ailus Cc: Mauro Carvalho Chehab, Hans Verkuil, Laurent Pinchart, linux-media, linux-api, linux-kernel, linux-doc Hi Sakari, On Fri, 14 Nov 2014 15:58:31 +0200 Sakari Ailus <sakari.ailus@iki.fi> wrote: > Hi Boris, > > On Fri, Nov 14, 2014 at 11:36:00AM +0100, Boris Brezillon wrote: > > Add RGB444_1X12 and RGB565_1X16 format definitions and update the > > documentation. > > > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> > > Acked-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> > > --- > > Documentation/DocBook/media/v4l/subdev-formats.xml | 40 ++++++++++++++++++++++ > > include/uapi/linux/media-bus-format.h | 4 ++- > > 2 files changed, 43 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml b/Documentation/DocBook/media/v4l/subdev-formats.xml > > index 18730b9..8c396db 100644 > > --- a/Documentation/DocBook/media/v4l/subdev-formats.xml > > +++ b/Documentation/DocBook/media/v4l/subdev-formats.xml > > @@ -563,6 +563,46 @@ > > <entry>b<subscript>1</subscript></entry> > > <entry>b<subscript>0</subscript></entry> > > </row> > > + <row id="MEDIA-BUS-FMT-RGB444-1X12"> > > + <entry>MEDIA_BUS_FMT_RGB444_1X12</entry> > > + <entry>0x100d</entry> > > + <entry></entry> > > + &dash-ent-20; > > + <entry>r<subscript>3</subscript></entry> > > + <entry>r<subscript>2</subscript></entry> > > + <entry>r<subscript>1</subscript></entry> > > + <entry>r<subscript>0</subscript></entry> > > + <entry>g<subscript>3</subscript></entry> > > + <entry>g<subscript>2</subscript></entry> > > + <entry>g<subscript>1</subscript></entry> > > + <entry>g<subscript>0</subscript></entry> > > + <entry>b<subscript>3</subscript></entry> > > + <entry>b<subscript>2</subscript></entry> > > + <entry>b<subscript>1</subscript></entry> > > + <entry>b<subscript>0</subscript></entry> > > + </row> > > + <row id="MEDIA-BUS-FMT-RGB565-1X16"> > > + <entry>MEDIA_BUS_FMT_RGB565_1X16</entry> > > + <entry>0x100d</entry> > > + <entry></entry> > > + &dash-ent-16; > > + <entry>r<subscript>4</subscript></entry> > > + <entry>r<subscript>3</subscript></entry> > > + <entry>r<subscript>2</subscript></entry> > > + <entry>r<subscript>1</subscript></entry> > > + <entry>r<subscript>0</subscript></entry> > > + <entry>g<subscript>5</subscript></entry> > > + <entry>g<subscript>4</subscript></entry> > > + <entry>g<subscript>3</subscript></entry> > > + <entry>g<subscript>2</subscript></entry> > > + <entry>g<subscript>1</subscript></entry> > > + <entry>g<subscript>0</subscript></entry> > > + <entry>b<subscript>4</subscript></entry> > > + <entry>b<subscript>3</subscript></entry> > > + <entry>b<subscript>2</subscript></entry> > > + <entry>b<subscript>1</subscript></entry> > > + <entry>b<subscript>0</subscript></entry> > > + </row> > > </tbody> > > </tgroup> > > </table> > > diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h > > index 23b4090..cc7b79e 100644 > > --- a/include/uapi/linux/media-bus-format.h > > +++ b/include/uapi/linux/media-bus-format.h > > @@ -33,7 +33,7 @@ > > > > #define MEDIA_BUS_FMT_FIXED 0x0001 > > > > -/* RGB - next is 0x100e */ > > +/* RGB - next is 0x1010 */ > > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001 > > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002 > > #define MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE 0x1003 > > @@ -47,6 +47,8 @@ > > #define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b > > #define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c > > #define MEDIA_BUS_FMT_ARGB8888_1X32 0x100d > > +#define MEDIA_BUS_FMT_RGB444_1X12 0x100e > > +#define MEDIA_BUS_FMT_RGB565_1X16 0x100f > > I'd arrange these according to BPP and bits per sample, both in the header > and documentation. I cannot keep both macro values and BPP/bits per sample in incrementing order. Are you sure you prefer to order macros in BPP/bits per sample order ? -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [media] Add RGB444_1X12 and RGB565_1X16 media bus formats 2014-11-14 15:04 ` Boris Brezillon @ 2014-11-15 14:49 ` Sakari Ailus 2014-11-16 8:19 ` Boris Brezillon 0 siblings, 1 reply; 5+ messages in thread From: Sakari Ailus @ 2014-11-15 14:49 UTC (permalink / raw) To: Boris Brezillon Cc: Mauro Carvalho Chehab, Hans Verkuil, Laurent Pinchart, linux-media, linux-api, linux-kernel, linux-doc Hi Boris, Boris Brezillon wrote: > Hi Sakari, > > On Fri, 14 Nov 2014 15:58:31 +0200 > Sakari Ailus <sakari.ailus@iki.fi> wrote: > >> Hi Boris, >> >> On Fri, Nov 14, 2014 at 11:36:00AM +0100, Boris Brezillon wrote: ... >>> diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h >>> index 23b4090..cc7b79e 100644 >>> --- a/include/uapi/linux/media-bus-format.h >>> +++ b/include/uapi/linux/media-bus-format.h >>> @@ -33,7 +33,7 @@ >>> >>> #define MEDIA_BUS_FMT_FIXED 0x0001 >>> >>> -/* RGB - next is 0x100e */ >>> +/* RGB - next is 0x1010 */ >>> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001 >>> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002 >>> #define MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE 0x1003 >>> @@ -47,6 +47,8 @@ >>> #define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b >>> #define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c >>> #define MEDIA_BUS_FMT_ARGB8888_1X32 0x100d >>> +#define MEDIA_BUS_FMT_RGB444_1X12 0x100e >>> +#define MEDIA_BUS_FMT_RGB565_1X16 0x100f >> >> I'd arrange these according to BPP and bits per sample, both in the header >> and documentation. > > I cannot keep both macro values and BPP/bits per sample in incrementing > order. Are you sure you prefer to order macros in BPP/bits per sample > order ? If you take a look elsewhere in the header, you'll notice that the ordering has preferred the BPP value (and other values with semantic significance) over the numeric value of the definition. I'd just prefer to keep it that way. This is also why the "next is" comments are there. -- Kind regards, Sakari Ailus sakari.ailus@iki.fi ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [media] Add RGB444_1X12 and RGB565_1X16 media bus formats 2014-11-15 14:49 ` Sakari Ailus @ 2014-11-16 8:19 ` Boris Brezillon 0 siblings, 0 replies; 5+ messages in thread From: Boris Brezillon @ 2014-11-16 8:19 UTC (permalink / raw) To: Sakari Ailus Cc: Mauro Carvalho Chehab, Hans Verkuil, Laurent Pinchart, linux-media, linux-api, linux-kernel, linux-doc On Sat, 15 Nov 2014 16:49:33 +0200 Sakari Ailus <sakari.ailus@iki.fi> wrote: > Hi Boris, > > Boris Brezillon wrote: > > Hi Sakari, > > > > On Fri, 14 Nov 2014 15:58:31 +0200 > > Sakari Ailus <sakari.ailus@iki.fi> wrote: > > > >> Hi Boris, > >> > >> On Fri, Nov 14, 2014 at 11:36:00AM +0100, Boris Brezillon wrote: > ... > >>> diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h > >>> index 23b4090..cc7b79e 100644 > >>> --- a/include/uapi/linux/media-bus-format.h > >>> +++ b/include/uapi/linux/media-bus-format.h > >>> @@ -33,7 +33,7 @@ > >>> > >>> #define MEDIA_BUS_FMT_FIXED 0x0001 > >>> > >>> -/* RGB - next is 0x100e */ > >>> +/* RGB - next is 0x1010 */ > >>> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001 > >>> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002 > >>> #define MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE 0x1003 > >>> @@ -47,6 +47,8 @@ > >>> #define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b > >>> #define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c > >>> #define MEDIA_BUS_FMT_ARGB8888_1X32 0x100d > >>> +#define MEDIA_BUS_FMT_RGB444_1X12 0x100e > >>> +#define MEDIA_BUS_FMT_RGB565_1X16 0x100f > >> > >> I'd arrange these according to BPP and bits per sample, both in the header > >> and documentation. > > > > I cannot keep both macro values and BPP/bits per sample in incrementing > > order. Are you sure you prefer to order macros in BPP/bits per sample > > order ? > > If you take a look elsewhere in the header, you'll notice that the > ordering has preferred the BPP value (and other values with semantic > significance) over the numeric value of the definition. I'd just prefer > to keep it that way. This is also why the "next is" comments are there. > My bad, I only had a look at RGB formats. I'll fix that. Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-11-16 8:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-14 10:36 [PATCH] [media] Add RGB444_1X12 and RGB565_1X16 media bus formats Boris Brezillon
[not found] ` <1415961360-14898-1-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-11-14 13:58 ` Sakari Ailus
2014-11-14 15:04 ` Boris Brezillon
2014-11-15 14:49 ` Sakari Ailus
2014-11-16 8:19 ` Boris Brezillon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).