Re: [PATCH v4 13/42] virtio_blk: v1.0 support

["Michael S. Tsirkin" <mst@redhat.com>]

On Wed, Nov 26, 2014 at 04:40:45PM +0100, David Hildenbrand wrote:
> > On Tue, Nov 25, 2014 at 06:55:16PM +0100, Cornelia Huck wrote:
> > > On Tue, 25 Nov 2014 18:42:18 +0200
> > > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> > > 
> > > > Based on patch by Cornelia Huck.
> > > > 
> > > > Note: for consistency, and to avoid sparse errors,
> > > >       convert all fields, even those no longer in use
> > > >       for virtio v1.0.
> > > > 
> > > > Reviewed-by: Thomas Huth <thuth@linux.vnet.ibm.com>
> > > > Reviewed-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
> > > > Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > > > ---
> > > >  include/uapi/linux/virtio_blk.h | 15 ++++-----
> > > >  drivers/block/virtio_blk.c      | 70 ++++++++++++++++++++++++-----------------
> > > >  2 files changed, 49 insertions(+), 36 deletions(-)
> > > > 
> > > 
> > > Is this sufficiently unchanged so that the original r-bs still hold?
> > 
> > You are right, I'm afraid I'll have to drop these.
> > Thomas, David, care to comment?
> 
> I've got this on my list, will try to find some spare time tomorrow!
> 
> > Even better - have the cycles to review the latest version?
> 
> Yes, will try.
> 
> > 

Thanks!
If/when you do, pls make sure to pick the latest version.
You can always get it from vhost-net branch in my tree.

I will likely post another version tomorrow: Cornelia
found a bug in virtio-scsi.


-- 
MST