From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [tpmdd-devel] [PATCH v7 04/10] tpm: rename chip->dev to chip->pdev Date: Thu, 27 Nov 2014 16:51:31 +0200 Message-ID: <20141127145111.GC24791@intel.com> References: <1415713513-16524-1-git-send-email-jarkko.sakkinen@linux.intel.com> <1415713513-16524-5-git-send-email-jarkko.sakkinen@linux.intel.com> <5474F855.7080207@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <5474F855.7080207-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stefan Berger Cc: Peter Huewe , Ashley Lai , Marcel Selhorst , christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, josh.triplett-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, jason.gunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org, trousers-tech-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-api@vger.kernel.org On Tue, Nov 25, 2014 at 04:44:53PM -0500, Stefan Berger wrote: > On 11/11/2014 08:45 AM, Jarkko Sakkinen wrote: > >Rename chip->dev to chip->pdev to make it explicit that this not the > >character device but actually represents the platform device. > > > >Signed-off-by: Jarkko Sakkinen > > > > > >diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h > >index 69f4003..b3a7c76 100644 > >--- a/drivers/char/tpm/tpm.h > >+++ b/drivers/char/tpm/tpm.h > >@@ -98,7 +98,7 @@ struct tpm_vendor_specific { > > #define TPM_PPI_VERSION_LEN 3 > > > > struct tpm_chip { > >- struct device *dev; /* Device stuff */ > >+ struct device *pdev; /* Device stuff */ > > const struct tpm_class_ops *ops; > > > > int dev_num; /* /dev/tpm# */ > > So this is the core requiring the renamings. I assume you got them all and > none were hidden in #if's or so. Yup, I basically did :argdo %s/chip->dev/chip->pdev/g for *.[ch]. > Reviewed-by: Stefan Berger /Jarkko