From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH v3 3/5] arm64: dts: Add support for Spreadtrum SC9836 SoC in dts and Makefile Date: Fri, 28 Nov 2014 16:40:47 +0000 Message-ID: <20141128164047.GL25883@leverpostej> References: <1416917818-10506-1-git-send-email-chunyan.zhang@spreadtrum.com> <1416917818-10506-4-git-send-email-chunyan.zhang@spreadtrum.com> <20141127115042.GE857@leverpostej> <20141127121214.GF11511@e104818-lin.cambridge.arm.com> <20141127134309.GJ857@leverpostej> <20141128142913.GB5393@localhost> <20141128143532.GI25883@leverpostej> <20141128144412.GG7144@arm.com> <20141128150325.GC24370@e104818-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20141128150325.GC24370@e104818-lin.cambridge.arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Catalin Marinas Cc: "andrew@lunn.ch" , "heiko@sntech.de" , "gnomes@lxorguk.ukuu.org.uk" , Will Deacon , Chunyan Zhang , "jason@lakedaemon.net" , "lanqing.liu@spreadtrum.com" , "arnd@arndb.de" , "corbet@lwn.net" , "zhang.lyra@gmail.com" , "zhizhou.zhang@spreadtrum.com" , "geng.ren@spreadtrum.com" , "m-karicheri2@ti.com" , "linux-arm-kernel@lists.infradead.org" , "linux-serial@vger.kernel.org" , "grant.likely@linaro.org" , "orsonzhai@gmail.com" , "florian.vaussard@epfl.ch" List-Id: linux-api@vger.kernel.org [...] > In the meantime I think we can be more tolerant: > > diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c > index 2133f9d59d06..87f67a93fcc7 100644 > --- a/drivers/clocksource/arm_arch_timer.c > +++ b/drivers/clocksource/arm_arch_timer.c > @@ -376,6 +376,8 @@ arch_timer_detect_rate(void __iomem *cntbase, struct device_node *np) > arch_timer_rate = readl_relaxed(cntbase + CNTFRQ); > else > arch_timer_rate = arch_timer_get_cntfrq(); > + } else if (IS_ENABLED(CONFIG_ARM64)) { > + pr_warn("Architected timer frequency overridden by DT (broken firmware?)\n"); > } That looks good to me. On a related note, it looks like my documentation patch [1] from a while back fell by the wayside. Does anyone fancy picking that up to go with this? Mark. [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-August/282830.html