From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johan Hovold Subject: Re: [PATCH v4] gpio: lib-sysfs: Add 'wakeup' attribute Date: Thu, 5 Feb 2015 11:33:04 +0100 Message-ID: <20150205103304.GH13757@localhost> References: <1421351389-11660-1-git-send-email-soren.brinkmann@xilinx.com> <20150116111108.GG30960@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?iso-8859-1?Q?S=F6ren?= Brinkmann Cc: Linus Walleij , Alexandre Courbot , Johan Hovold , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux Kernel Mailing List , "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-api@vger.kernel.org On Wed, Feb 04, 2015 at 10:27:15AM -0800, S=F6ren Brinkmann wrote: > On Wed, 2015-02-04 at 10:19AM +0100, Linus Walleij wrote: > > What needs to happen (IMHO) is to make gpio_chips properly obeying > > the device model, and then add the attributes for fiddling around w= ith > > GPIOs to either the *real* device or create a new char device inter= face. > > Whatever works best. These mock devices are fragile and never > > worked properly especially in the removal path as Johans recent > > fixes has shown. >=20 > Sure, that would be a nice long-term solution. But until then this pa= tch > would probably be welcomed by some people, without making the brokenn= ess > of this interface much worse. We don't knowingly add broken functionality, and especially not when it will become ABI that needs to be maintained forever. And "this might be useful for someone at some point" is certainly not a reason to break that rule. Johan