From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH v2 04/18] clocksource: Add ARM System timer driver Date: Mon, 9 Mar 2015 23:17:52 +0100 Message-ID: <20150309221752.GE7525@pengutronix.de> References: <1424455277-29983-1-git-send-email-mcoquelin.stm32@gmail.com> <1424455277-29983-5-git-send-email-mcoquelin.stm32@gmail.com> <20150220195437.GT19388@pengutronix.de> <1424468908.24292.10.camel@x220> <1425411786.2606.24.camel@tiscali.nl> <1425935552.4244.6.camel@x220> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1425935552.4244.6.camel@x220> Sender: linux-doc-owner@vger.kernel.org To: Paul Bolle Cc: Maxime Coquelin , Andreas =?iso-8859-1?Q?F=E4rber?= , Geert Uytterhoeven , Rob Herring , Philipp Zabel , Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Daniel Lezcano , Thomas Gleixner , Linus Walleij , Greg Kroah-Hartman , Jiri Slaby , Arnd Bergmann , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Joe Perches , Antti Palosaari , Tejun List-Id: linux-api@vger.kernel.org Hello, On Mon, Mar 09, 2015 at 10:12:32PM +0100, Paul Bolle wrote: > On Wed, 2015-03-04 at 13:08 +0100, Maxime Coquelin wrote: > > This is because I added also support for COMPILE_TEST coverage as p= er > > Uwe advice, > > and thought it was necessary to have an entry for this. > > Maybe I'm just wrong? >=20 > I missed that you added COMPILE_TEST. >=20 > A quick scan of your idea doesn't show any obvious issues. (Note that= I > don't really know how people actually use COMPILE_TEST. I guess thing= s > like "make allyesconfig" are involved.) Maybe this can clearify the purpose of COMPILE_TEST: diff --git a/init/Kconfig b/init/Kconfig --- a/init/Kconfig +++ b/init/Kconfig @@ -67,6 +67,26 @@ config COMPILE_TEST here. If you are a user/distributor, say N here to exclude useless drivers to be distributed. =20 + # If you are a driver author consider to adjust your driver's + # dependencies to make it buildable with minimal preconditions if + # COMPILE_TEST is enabled. This helps contributers and maintainers + # that might not have the necessary toolchain or kernel config handy = and + # also increases compile test coverage. It's your advantage if others= can + # build your driver more easily! So for a device that is only found o= n the + # foo cpu use: + # + # depends on CPU_FOO || COMPILE_TEST + # + # . You might have to use + # + # depends on CPU_FOO || (COMPILE_TEST && COOKIE) + # + # or + # + # depends on COOKIE && (CPU_FOO || COMPILE_TEST) + # + # if your driver uses features that are only available if COOKIE is o= n. + config LOCALVERSION string "Local version - append to kernel release" help --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig = | Industrial Linux Solutions | http://www.pengutronix.de/= |