[PATCH 0/3] selftests: ptrace, kcmp, efivars build failure fixes

[PATCH 0/3] selftests: ptrace, kcmp, efivars build failure fixes

[Shuah Khan]

ptrace, efivars, and kcmp Makefiles don't have explicit build rule.
As a result, build fails when make is run from top level Makefile
target kselftest. Without the explicit rule, make works only when
it is run in the current directory or from selftests directory.
Fxing the problems by adding an explicit build rule to fix the
problem.

Shuah Khan (3):
  selftests: ptrace build fails when invoked from kselftest target
  selftests: efivars build fails when invoked from kselftest target
  selftests: kcmp build fails when invoked from kselftest target

 tools/testing/selftests/efivarfs/Makefile | 2 ++
 tools/testing/selftests/kcmp/Makefile     | 5 +++--
 tools/testing/selftests/ptrace/Makefile   | 5 +++--
 3 files changed, 8 insertions(+), 4 deletions(-)

-- 
2.1.0

[PATCH 3/3] selftests: kcmp build fails when invoked from kselftest target

[Shuah Khan]

kcmp Makefile doesn't have an explicit build rule. As a result,
kcmp build fails, when it is run from top level Makefile target
kselftest. Without the explicit rule, make works only when it is
run in the current directory or from selftests directory. Add an
explicit build rule to fix the problem. In addition, build fails
as it can't find kcmp.h. Fix it by passing CFLAGS.

Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
 tools/testing/selftests/kcmp/Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/kcmp/Makefile b/tools/testing/selftests/kcmp/Makefile
index ff0eefd..83383eb 100644
--- a/tools/testing/selftests/kcmp/Makefile
+++ b/tools/testing/selftests/kcmp/Makefile
@@ -1,7 +1,8 @@
 CC := $(CROSS_COMPILE)$(CC)
-CFLAGS += -I../../../../usr/include/
+CFLAGS += -I../../../../include/uapi -I../../../../usr/include/
 
-all: kcmp_test
+all:
+	$(CC) $(CFLAGS) kcmp_test.c -o kcmp_test
 
 run_tests: all
 	@./kcmp_test || echo "kcmp_test: [FAIL]"
-- 
2.1.0

Re: [PATCH 3/3] selftests: kcmp build fails when invoked from kselftest target

[Cyrill Gorcunov]

On Tue, Mar 10, 2015 at 04:00:59PM -0600, Shuah Khan wrote:
> kcmp Makefile doesn't have an explicit build rule. As a result,
> kcmp build fails, when it is run from top level Makefile target
> kselftest. Without the explicit rule, make works only when it is
> run in the current directory or from selftests directory. Add an
> explicit build rule to fix the problem. In addition, build fails
> as it can't find kcmp.h. Fix it by passing CFLAGS.
> 
> Signed-off-by: Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
> ---
>  tools/testing/selftests/kcmp/Makefile | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/kcmp/Makefile b/tools/testing/selftests/kcmp/Makefile
> index ff0eefd..83383eb 100644
> --- a/tools/testing/selftests/kcmp/Makefile
> +++ b/tools/testing/selftests/kcmp/Makefile
> @@ -1,7 +1,8 @@
>  CC := $(CROSS_COMPILE)$(CC)
> -CFLAGS += -I../../../../usr/include/
> +CFLAGS += -I../../../../include/uapi -I../../../../usr/include/
>  
> -all: kcmp_test
> +all:
> +	$(CC) $(CFLAGS) kcmp_test.c -o kcmp_test
>  
>  run_tests: all
>  	@./kcmp_test || echo "kcmp_test: [FAIL]"

Ho Shuah! Thanks for looking into it. I've a small question --
why kcmp_test prerequsite is dropped? As to me it should remain
here, except explicit build rule added.

Re: [PATCH 3/3] selftests: kcmp build fails when invoked from kselftest target

[Shuah Khan]

On 03/10/2015 04:09 PM, Cyrill Gorcunov wrote:
> On Tue, Mar 10, 2015 at 04:00:59PM -0600, Shuah Khan wrote:
>> kcmp Makefile doesn't have an explicit build rule. As a result,
>> kcmp build fails, when it is run from top level Makefile target
>> kselftest. Without the explicit rule, make works only when it is
>> run in the current directory or from selftests directory. Add an
>> explicit build rule to fix the problem. In addition, build fails
>> as it can't find kcmp.h. Fix it by passing CFLAGS.
>>
>> Signed-off-by: Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
>> ---
>>  tools/testing/selftests/kcmp/Makefile | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/testing/selftests/kcmp/Makefile b/tools/testing/selftests/kcmp/Makefile
>> index ff0eefd..83383eb 100644
>> --- a/tools/testing/selftests/kcmp/Makefile
>> +++ b/tools/testing/selftests/kcmp/Makefile
>> @@ -1,7 +1,8 @@
>>  CC := $(CROSS_COMPILE)$(CC)
>> -CFLAGS += -I../../../../usr/include/
>> +CFLAGS += -I../../../../include/uapi -I../../../../usr/include/
>>  
>> -all: kcmp_test
>> +all:
>> +	$(CC) $(CFLAGS) kcmp_test.c -o kcmp_test
>>  
>>  run_tests: all
>>  	@./kcmp_test || echo "kcmp_test: [FAIL]"
> 
> Ho Shuah! Thanks for looking into it. I've a small question --
> why kcmp_test prerequsite is dropped? As to me it should remain
> here, except explicit build rule added.
> 

Are you looking for something like this:

all: kcmp_test

kcmp_test:
	$(CC) $(CFLAGS) kcmp_test.c -o kcmp_test

I just simplified it and removed the prerequsite.
If you prefer, I can make the change to keep the
prereq.


thanks,
-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978

Re: [PATCH 3/3] selftests: kcmp build fails when invoked from kselftest target

[Cyrill Gorcunov]

On Tue, Mar 10, 2015 at 04:41:39PM -0600, Shuah Khan wrote:
> 
> Are you looking for something like this:
> 
> all: kcmp_test
> 
> kcmp_test:
> 	$(CC) $(CFLAGS) kcmp_test.c -o kcmp_test
> 
> I just simplified it and removed the prerequsite.
> If you prefer, I can make the change to keep the
> prereq.

Yes please, and you may use internal make var $@ as well

kcmp_test:
	$(CC) $(CFLAGS) kcmp_test.c -o $@

[PATCH 1/3] selftests: ptrace build fails when invoked from kselftest target

[Shuah Khan]

ptrace Makefile doesn't have an explicit build rule. As a result,
ptrace build fails, when it is run from top level Makefile target
kselftest. Without the explicit rule, make works only when it is
run in the current directory or from selftests directory. Add an
explicit build rule to fix the problem.

Signed-off-by: Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
---
 tools/testing/selftests/ptrace/Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/ptrace/Makefile b/tools/testing/selftests/ptrace/Makefile
index 47ae2d3..9067567 100644
--- a/tools/testing/selftests/ptrace/Makefile
+++ b/tools/testing/selftests/ptrace/Makefile
@@ -1,7 +1,8 @@
+CC := $(CROSS_COMPILE)$(CC)
 CFLAGS += -iquote../../../../include/uapi -Wall
-peeksiginfo: peeksiginfo.c
 
-all: peeksiginfo
+all:
+	$(CC) $(CFLAGS) peeksiginfo.c -o peeksiginfo
 
 clean:
 	rm -f peeksiginfo
-- 
2.1.0

[PATCH 2/3] selftests: efivars build fails when invoked from kselftest target

[Shuah Khan]

efivars Makefile doesn't have an explicit build rule. As a result,
efivars build fails, when it is run from top level Makefile target
kselftest. Without the explicit rule, make works only when it is
run in the current directory or from selftests directory. Add an
explicit build rule to fix the problem.

Signed-off-by: Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
---
 tools/testing/selftests/efivarfs/Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/efivarfs/Makefile b/tools/testing/selftests/efivarfs/Makefile
index 29e8c6b..bb48d73 100644
--- a/tools/testing/selftests/efivarfs/Makefile
+++ b/tools/testing/selftests/efivarfs/Makefile
@@ -4,6 +4,8 @@ CFLAGS = -Wall
 test_objs = open-unlink create-read
 
 all: $(test_objs)
+%: %.c
+	$(CC) $(CFLAGS) -o $@ $^
 
 run_tests: all
 	@/bin/bash ./efivarfs.sh || echo "efivarfs selftests: [FAIL]"
-- 
2.1.0

Re: [PATCH 0/3] selftests: ptrace, kcmp, efivars build failure fixes

[Michael Ellerman]

On Tue, 2015-03-10 at 16:00 -0600, Shuah Khan wrote:
> ptrace, efivars, and kcmp Makefiles don't have explicit build rule.
> As a result, build fails when make is run from top level Makefile
> target kselftest. Without the explicit rule, make works only when
> it is run in the current directory or from selftests directory.
> Fxing the problems by adding an explicit build rule to fix the
> problem.
> 
> Shuah Khan (3):
>   selftests: ptrace build fails when invoked from kselftest target
>   selftests: efivars build fails when invoked from kselftest target
>   selftests: kcmp build fails when invoked from kselftest target
> 
>  tools/testing/selftests/efivarfs/Makefile | 2 ++
>  tools/testing/selftests/kcmp/Makefile     | 5 +++--
>  tools/testing/selftests/ptrace/Makefile   | 5 +++--
>  3 files changed, 8 insertions(+), 4 deletions(-)

What? No. This is the bug my patch to filter the make flags fixes.

cheers

Re: [PATCH 0/3] selftests: ptrace, kcmp, efivars build failure fixes

[Shuah Khan]

On 03/10/2015 05:35 PM, Michael Ellerman wrote:
> On Tue, 2015-03-10 at 16:00 -0600, Shuah Khan wrote:
>> ptrace, efivars, and kcmp Makefiles don't have explicit build rule.
>> As a result, build fails when make is run from top level Makefile
>> target kselftest. Without the explicit rule, make works only when
>> it is run in the current directory or from selftests directory.
>> Fxing the problems by adding an explicit build rule to fix the
>> problem.
>>
>> Shuah Khan (3):
>>   selftests: ptrace build fails when invoked from kselftest target
>>   selftests: efivars build fails when invoked from kselftest target
>>   selftests: kcmp build fails when invoked from kselftest target
>>
>>  tools/testing/selftests/efivarfs/Makefile | 2 ++
>>  tools/testing/selftests/kcmp/Makefile     | 5 +++--
>>  tools/testing/selftests/ptrace/Makefile   | 5 +++--
>>  3 files changed, 8 insertions(+), 4 deletions(-)
> 
> What? No. This is the bug my patch to filter the make flags fixes.
> 
> cheers
> 
> 

Michael,

Did you see my email from yesterday on how your patch introduced
more problems. Can you please make sure the patches you send work
and don't introduce problems. I am having this issue with a lot
of your patches.

thanks,
-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978

Re: [PATCH 0/3] selftests: ptrace, kcmp, efivars build failure fixes

[Shuah Khan]

On 03/10/2015 05:37 PM, Shuah Khan wrote:
> On 03/10/2015 05:35 PM, Michael Ellerman wrote:
>> On Tue, 2015-03-10 at 16:00 -0600, Shuah Khan wrote:
>>> ptrace, efivars, and kcmp Makefiles don't have explicit build rule.
>>> As a result, build fails when make is run from top level Makefile
>>> target kselftest. Without the explicit rule, make works only when
>>> it is run in the current directory or from selftests directory.
>>> Fxing the problems by adding an explicit build rule to fix the
>>> problem.
>>>
>>> Shuah Khan (3):
>>>   selftests: ptrace build fails when invoked from kselftest target
>>>   selftests: efivars build fails when invoked from kselftest target
>>>   selftests: kcmp build fails when invoked from kselftest target
>>>
>>>  tools/testing/selftests/efivarfs/Makefile | 2 ++
>>>  tools/testing/selftests/kcmp/Makefile     | 5 +++--
>>>  tools/testing/selftests/ptrace/Makefile   | 5 +++--
>>>  3 files changed, 8 insertions(+), 4 deletions(-)
>>
>> What? No. This is the bug my patch to filter the make flags fixes.
>>
>> cheers
>>
>>
> 
> Michael,
> 
> Did you see my email from yesterday on how your patch introduced
> more problems. Can you please make sure the patches you send work
> and don't introduce problems. I am having this issue with a lot
> of your patches.
> 

btw your patch doesn't fix the header file include problem. I don't
see any reason why individual Makefile shouldn't address this problem.

thanks,
-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978