From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix definition of the DRM_IOCTL_I915_GET_SPRITE_COLORKEY ioctl Date: Fri, 27 Mar 2015 09:04:28 +0100 Message-ID: <20150327080427.GB23521@phenom.ffwll.local> References: <1427399236-14012-1-git-send-email-tt.rantala@gmail.com> <87a8yzq6yr.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <87a8yzq6yr.fsf-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jani Nikula Cc: Tommi Rantala , Daniel Vetter , David Airlie , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, "Barnes, Jesse" List-Id: linux-api@vger.kernel.org On Fri, Mar 27, 2015 at 08:39:56AM +0200, Jani Nikula wrote: > On Thu, 26 Mar 2015, Tommi Rantala wrote: > > Fix definition of the DRM_IOCTL_I915_GET_SPRITE_COLORKEY ioctl, so that it > > is different from the DRM_IOCTL_I915_SET_SPRITE_COLORKEY ioctl. > > > > Signed-off-by: Tommi Rantala > > Whoa. Broken since its introduction in > > commit 8ea30864229e54b01ac0e9fe88c4b733a940ec4e > Author: Jesse Barnes > Date: Tue Jan 3 08:05:39 2012 -0800 > > drm/i915: add color key support v4 > > Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Nope, we'll just rip it out and replace it all with the drm_noop ioctl. At least I didn't find any userspace anywhere and only broken definitions. Proof enough this isn't useful. Even more so since that means we don't have to convert the get ioctl over to atomic, yay! I'll send patches. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch