From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 01/86] pci: export pci_ids.h Date: Mon, 30 Mar 2015 13:41:28 +0200 Message-ID: <20150330134002-mutt-send-email-mst@redhat.com> References: <20150330083707-mutt-send-email-mst@redhat.com> <20150330065522.GA10105@kroah.com> <20150330085617-mutt-send-email-mst@redhat.com> <20150330075331.GA17823@kroah.com> <20150330101830-mutt-send-email-mst@redhat.com> <20150330100744.GA16291@kroah.com> <20150330123051-mutt-send-email-mst@redhat.com> <20150330105707.GA17979@kroah.com> <20150330130020-mutt-send-email-mst@redhat.com> <20150330113516.GA19501@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20150330113516.GA19501-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Greg KH Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Bjorn Helgaas , Jonathan Corbet , "David S. Miller" , Hans Verkuil , Mauro Carvalho Chehab , Alexei Starovoitov , stephen hemminger , Masahiro Yamada , Andy Shevchenko , Andy Lutomirski , Rasmus Villemoes , Stephane Eranian , Huang Rui , Peter Neubauer , linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-api@vger.kernel.org On Mon, Mar 30, 2015 at 01:35:16PM +0200, Greg KH wrote: > On Mon, Mar 30, 2015 at 01:19:14PM +0200, Michael S. Tsirkin wrote: > > Why there much more that two packages, I can find > > at least 5 copies in the wild. Why? I think it's because it's part of > > linux ABI that doesn't have matching headers. People are asked to build > > their own, so of course they copy each other. > > > > Once linux exports these headers everyone can stop > > duplicating each other and others, and just use linux headers too. > > As I'm not the PCI maintainer anymore, I'll let Bjorn decide about this. > > But, your original patch series isn't ok, we don't want to export the > pci vendor/device ids to userspace, that isn't the job of the kernel to > do so. If we should be exporting the pci class and config structures or > not is Bjorn's decision. > > greg k-h I sent v2 doing exactly that. Thanks a lot for the review. -- MST