From: Jonathan Corbet <corbet@lwn.net>
To: josh@joshtriplett.org
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Lutomirski <luto@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Kees Cook <keescook@chromium.org>,
Oleg Nesterov <oleg@redhat.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
"H. Peter Anvin" <hpa@zytor.com>, Rik van Riel <riel@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Thiago Macieira <thiago.macieira@intel.com>,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
linux-fsdevel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH v2 0/7] CLONE_FD: Task exit notification via file descriptor
Date: Wed, 1 Apr 2015 09:24:20 +0200 [thread overview]
Message-ID: <20150401092420.4c1dbb6e@lwn.net> (raw)
In-Reply-To: <20150331220224.GA22707@cloud>
On Tue, 31 Mar 2015 15:02:24 -0700
josh@joshtriplett.org wrote:
> > This would appear to assume that a clonefd_info structure is the only
> > thing that will ever be read from this descriptor. It seems to me that
> > there is the potential for, someday, wanting to be able to read and write
> > other things as well. Should this structure be marked with type and
> > length fields so that other structures could be added in the future?
>
> I don't think it makes sense for a caller to get an arbitrary structure
> on read(), and have to figure out what they got and ignore something
> they don't understand. Instead, I think it makes more sense for the
> caller to say "Hey, here's a flag saying I understand the new thing, go
> ahead and give me the new thing". So, for instance, if you want to
> receive SIGSTOP/SIGCONT messages for child processes through this
> descriptor, we could add a flag for that.
The flag is fine, but, once we have set that flag saying we want those
messages, how do we know which type of structure we've gotten? That's
the piece of the puzzle I'm missing, sorry if I'm being overly slow.
Thanks,
jon
next prev parent reply other threads:[~2015-04-01 7:24 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-15 7:59 [PATCH v2 0/7] CLONE_FD: Task exit notification via file descriptor Josh Triplett
2015-03-15 7:59 ` [PATCH v2 1/7] clone: Support passing tls argument via C rather than pt_regs magic Josh Triplett
2015-03-15 7:59 ` [PATCH v2 3/7] Introduce a new clone4 syscall with more flag bits and extensible arguments Josh Triplett
[not found] ` <367b888ef58831b6812c3cf80ca973c65edc67f5.1426376419.git.josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org>
2015-03-23 14:11 ` David Drysdale
2015-03-23 15:05 ` josh
2015-03-31 14:41 ` David Drysdale
2015-03-15 7:59 ` [PATCH v2 4/7] kernel/fork.c: Pass arguments to _do_fork and copy_process using clone4_args Josh Triplett
2015-03-15 8:00 ` [PATCH v2 5/7] clone4: Add a CLONE_AUTOREAP flag to automatically reap the child process Josh Triplett
[not found] ` <6d002995485d446e659105f6931307f3e532ce89.1426376419.git.josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org>
2015-03-15 14:52 ` Oleg Nesterov
[not found] ` <20150315145223.GA21887-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-03-15 17:18 ` Josh Triplett
2015-03-15 19:55 ` Oleg Nesterov
[not found] ` <20150315195506.GA29475-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-03-15 23:34 ` Josh Triplett
2015-03-20 18:14 ` Oleg Nesterov
2015-03-20 18:46 ` Thiago Macieira
2015-03-20 19:09 ` Oleg Nesterov
2015-03-20 21:10 ` josh
2015-03-15 8:00 ` [PATCH v2 6/7] signal: Factor out a helper function to process task_struct exit_code Josh Triplett
2015-03-15 8:00 ` [PATCH v2 7/7] clone4: Add a CLONE_FD flag to get task exit notification via fd Josh Triplett
2015-03-23 17:38 ` David Drysdale
2015-03-25 14:53 ` Josh Triplett
[not found] ` <fdec4b70c7cd34e2eacf6a0e41d36f606a696da1.1426376419.git.josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org>
2015-04-06 8:30 ` Sergey Senozhatsky
2015-04-06 9:31 ` Josh Triplett
2015-03-15 8:00 ` [PATCH v2 man-pages] clone4.2: New manpage documenting clone4(2) Josh Triplett
[not found] ` <cover.1426376419.git.josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org>
2015-03-15 7:59 ` [PATCH v2 2/7] x86: Opt into HAVE_COPY_THREAD_TLS, for both 32-bit and 64-bit Josh Triplett
2015-03-15 8:04 ` [PATCH v2 0/7] CLONE_FD: Task exit notification via file descriptor Josh Triplett
2015-05-29 7:43 ` Florian Weimer
2015-05-29 20:27 ` Thiago Macieira
2015-06-15 10:06 ` Florian Weimer
2015-03-16 21:44 ` Kees Cook
[not found] ` <CAGXu5jLmLLgVNCP=cyUiXuiszVXsS88SNUK2iBqArbA2V6vdHA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-16 22:14 ` Thiago Macieira
2015-03-16 22:36 ` Kees Cook
[not found] ` <CAGXu5jJr_DieZ281=H0ZNtNvOagO0pm8PRfNvRWKp4YwS=55GA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-16 22:50 ` Thiago Macieira
2015-03-16 23:26 ` Kees Cook
2015-03-16 23:35 ` josh
2015-03-16 23:29 ` josh-iaAMLnmF4UmaiuxdJuQwMA
2015-03-17 0:49 ` Thiago Macieira
2015-03-23 14:12 ` David Drysdale
2015-03-23 15:03 ` josh
2015-03-16 23:25 ` josh-iaAMLnmF4UmaiuxdJuQwMA
2015-03-31 20:08 ` Jonathan Corbet
2015-03-31 22:02 ` josh
2015-04-01 7:24 ` Jonathan Corbet [this message]
[not found] ` <20150401092420.4c1dbb6e-T1hC0tSOHrs@public.gmane.org>
2015-04-09 2:19 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150401092420.4c1dbb6e@lwn.net \
--to=corbet@lwn.net \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=josh@joshtriplett.org \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=mtk.manpages@gmail.com \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
--cc=thiago.macieira@intel.com \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).