From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hildenbrand Subject: Re: [PATCH v2 01/10] KVM: add commentary for kvm_debug_exit_arch struct Date: Wed, 1 Apr 2015 17:38:36 +0200 Message-ID: <20150401173836.09f7fde1@thinkpad-w530> References: <1427814488-28467-1-git-send-email-alex.bennee@linaro.org> <1427814488-28467-2-git-send-email-alex.bennee@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1427814488-28467-2-git-send-email-alex.bennee-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alex =?UTF-8?B?QmVubsOpZQ==?= Cc: kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, kvmarm-FPEHb7Xf0XXUo1n7N8X6UoWGPAHP3yOg@public.gmane.org, christoffer.dall-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, marc.zyngier-5wv7dgnIgG8@public.gmane.org, peter.maydell-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, agraf-l3A5Bk7waGM@public.gmane.org, drjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, zhichao.huang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org, r65777-KZfg59tc24xl57MIdRCFDg@public.gmane.org, bp-l3A5Bk7waGM@public.gmane.org, Gleb Natapov , "open list:ABI/API" , open list List-Id: linux-api@vger.kernel.org > Bring into line with the commentary for the other structures and thei= r > KVM_EXIT_* cases. s/commentary/comments/ in the subject and description. Unless you want = to add a lengthy discussion :) >=20 > Signed-off-by: Alex Benn=C3=A9e >=20 > --- >=20 > v2 > - add comments for other exit types >=20 > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > index 8055706..5eedf84 100644 > --- a/include/uapi/linux/kvm.h > +++ b/include/uapi/linux/kvm.h > @@ -226,6 +226,7 @@ struct kvm_run { > __u32 count; > __u64 data_offset; /* relative to kvm_run start */ > } io; > + /* KVM_EXIT_DEBUG */ > struct { > struct kvm_debug_exit_arch arch; > } debug; > @@ -274,6 +275,7 @@ struct kvm_run { > __u32 data; > __u8 is_write; > } dcr; > + /* KVM_EXIT_INTERNAL_ERROR */ > struct { > __u32 suberror; > /* Available with KVM_CAP_INTERNAL_ERROR_DATA: */ > @@ -284,6 +286,7 @@ struct kvm_run { > struct { > __u64 gprs[32]; > } osi; > + /* KVM_EXIT_PAPR_HCALL */ > struct { > __u64 nr; > __u64 ret; Looks good to me. David