From: Jean Delvare <jdelvare@suse.de>
To: Ivan Khoronzhuk <ivan.khoronzhuk@globallogic.com>
Cc: linux-kernel@vger.kernel.org, matt.fleming@intel.com,
ard.biesheuvel@linaro.org, grant.likely@linaro.org,
linux-api@vger.kernel.org, linux-doc@vger.kernel.org,
mikew@google.com, dmidecode-devel@nongnu.org,
leif.lindholm@linaro.org, msalter@redhat.com,
roy.franz@linaro.org
Subject: Re: [Patch 1/3] firmware: dmi_scan: rename dmi_table to dmi_decode_table
Date: Wed, 15 Apr 2015 13:51:12 +0200 [thread overview]
Message-ID: <20150415135112.494d14f9@endymion.delvare> (raw)
In-Reply-To: <1427979423-22767-2-git-send-email-ivan.khoronzhuk@globallogic.com>
On Thu, 2 Apr 2015 15:57:01 +0300, Ivan Khoronzhuk wrote:
> The "dmi_table" function looks like data instance, but it does DMI
> table decode. This patch renames it to "dmi_decode_table" name as
> more appropriate. That allows us to use "dmi_table" name for correct
> purposes.
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@globallogic.com>
> ---
> drivers/firmware/dmi_scan.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
> (...)
Yes, as discussed before, good idea.
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2015-04-15 11:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 12:57 [Patch 0/3] firmware: dmi_scan: add SBMIOS entry point and DMI tables Ivan Khoronzhuk
[not found] ` <1427979423-22767-1-git-send-email-ivan.khoronzhuk-hExfYMNmJl/Cnp4W7fqMDg@public.gmane.org>
2015-04-02 12:57 ` [Patch 1/3] firmware: dmi_scan: rename dmi_table to dmi_decode_table Ivan Khoronzhuk
2015-04-15 11:51 ` Jean Delvare [this message]
[not found] ` <1427979423-22767-2-git-send-email-ivan.khoronzhuk-hExfYMNmJl/Cnp4W7fqMDg@public.gmane.org>
2015-04-15 14:35 ` Matt Fleming
[not found] ` <20150415143530.GF4804-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-04-16 8:35 ` Jean Delvare
2015-04-16 20:16 ` Ivan.khoronzhuk
2015-04-17 8:54 ` Jean Delvare
2015-04-17 10:11 ` Ivan.khoronzhuk
2015-04-17 12:04 ` Ivan.khoronzhuk
[not found] ` <5530F6C7.6060306-hExfYMNmJl/Cnp4W7fqMDg@public.gmane.org>
2015-04-17 12:50 ` Jean Delvare
2015-04-17 13:40 ` Matt Fleming
2015-04-17 14:12 ` [dmidecode] " Jean Delvare
2015-04-02 12:57 ` [Patch 2/3] firmware: dmi_scan: add SBMIOS entry and DMI tables Ivan Khoronzhuk
2015-04-03 9:36 ` Ivan.khoronzhuk
[not found] ` <551E5F0B.6050709-hExfYMNmJl/Cnp4W7fqMDg@public.gmane.org>
2015-04-15 4:19 ` Roy Franz
[not found] ` <CAFECyb_BGU82vCi0jOz+MbdsxRS-jFoHNsZe5KdOCgpt0K7y+A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-16 0:54 ` Roy Franz
[not found] ` <CAFECyb9RFAEWMOFCDcKKYBgQk85HoDiG2yfyou6X9qm=Wq5+Pg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-16 6:48 ` Jean Delvare
2015-04-16 17:08 ` Roy Franz
2015-04-16 9:52 ` Jean Delvare
[not found] ` <20150416115252.7dc964a3-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2015-04-16 12:56 ` Ivan.khoronzhuk
2015-04-16 15:44 ` [dmidecode] " Jean Delvare
2015-04-16 17:27 ` subscivan
[not found] ` <552FF0E4.709-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-16 17:32 ` Ivan.khoronzhuk
2015-04-17 13:02 ` Jean Delvare
2015-04-02 12:57 ` [Patch 3/3] Documentation: ABI: sysfs-firmware-dmi: add -entries suffix to file name Ivan Khoronzhuk
2015-04-15 11:52 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150415135112.494d14f9@endymion.delvare \
--to=jdelvare@suse.de \
--cc=ard.biesheuvel@linaro.org \
--cc=dmidecode-devel@nongnu.org \
--cc=grant.likely@linaro.org \
--cc=ivan.khoronzhuk@globallogic.com \
--cc=leif.lindholm@linaro.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mikew@google.com \
--cc=msalter@redhat.com \
--cc=roy.franz@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).