Re: [PATCH v6 3/8] macvtap: introduce macvtap_is_little_endian() helper

Michael S. Tsirkin
2015-06-01T10:30:16Z

On Fri, Apr 24, 2015 at 02:24:48PM +0200, Greg Kurz wrote:
> Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>

Dave, could you pls ack merging this through the virtio tree?

> ---
> drivers/net/macvtap.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
> index 27ecc5c..a2f2958 100644
> --- a/drivers/net/macvtap.c
> +++ b/drivers/net/macvtap.c
> @@ -49,14 +49,19 @@ struct macvtap_queue {
>
> #define MACVTAP_VNET_LE 0x80000000
>
> +static inline bool macvtap_is_little_endian(struct macvtap_queue *q)
> +{
> + return q->flags & MACVTAP_VNET_LE;
> +}
> +
> static inline u16 macvtap16_to_cpu(struct macvtap_queue *q, __virtio16 val)
> {
> - return __virtio16_to_cpu(q->flags & MACVTAP_VNET_LE, val);
> + return __virtio16_to_cpu(macvtap_is_little_endian(q), val);
> }
>
> static inline __virtio16 cpu_to_macvtap16(struct macvtap_queue *q, u16 val)
> {
> - return __cpu_to_virtio16(q->flags & MACVTAP_VNET_LE, val);
> + return __cpu_to_virtio16(macvtap_is_little_endian(q), val);
> }
>
> static struct proto macvtap_proto = {
>
> _______________________________________________
> Virtualization mailing list
> Virtualization@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/virtualization