Linux userland API discussions
 help / color / mirror / Atom feed
From: Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
To: "Seymour, Shane M" <shane.seymour-VXdhtT5mjnY@public.gmane.org>
Cc: ISS StorageDev <iss_storagedev-VXdhtT5mjnY@public.gmane.org>,
	"James Bottomley (JBottomley-O3H1v1f1dlM@public.gmane.org)"
	<JBottomley-O3H1v1f1dlM@public.gmane.org>,
	"linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2] hpsa: convert DEVICE_ATTR to RO|WO|RW and show methods must not use snprintf
Date: Tue, 30 Jun 2015 19:29:43 -0700	[thread overview]
Message-ID: <20150701022943.GA22097@kroah.com> (raw)
In-Reply-To: <DDB9C85B850785449757F9914A034FCB4442D0E6-4I1V4pQFGigSZAcGdq5asR6epYMZPwEe5NbjCUgZEJk@public.gmane.org>

On Wed, Jul 01, 2015 at 01:56:03AM +0000, Seymour, Shane M wrote:
> 
> Changed DEVICE_ATTR macro usage to DEVICE_ATTR_RO|WO|RW.
> This also forced some show/store function names to change.
> 
> Changed all show method snprintf() usage to scnprintf() per
> Documentation/filesystems/sysfs.txt.

Forgot to mention this before, but you are doing two different things,
so this really should be 2 different patches.

But I'm not the scsi maintainer, maybe they have more lax acceptance
rules here :)

thanks,

greg k-h

      parent reply	other threads:[~2015-07-01  2:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-01  1:56 [PATCH v2] hpsa: convert DEVICE_ATTR to RO|WO|RW and show methods must not use snprintf Seymour, Shane M
     [not found] ` <DDB9C85B850785449757F9914A034FCB4442D0E6-4I1V4pQFGigSZAcGdq5asR6epYMZPwEe5NbjCUgZEJk@public.gmane.org>
2015-07-01  2:29   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150701022943.GA22097@kroah.com \
    --to=greg-u8xffu+wg4eavxtiumwx3w@public.gmane.org \
    --cc=JBottomley-O3H1v1f1dlM@public.gmane.org \
    --cc=iss_storagedev-VXdhtT5mjnY@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=shane.seymour-VXdhtT5mjnY@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox