From: Seth Forshee <seth.forshee@canonical.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
"Linux Containers" <containers@lists.linux-foundation.org>,
linux-fsdevel@vger.kernel.org,
"Linux API" <linux-api@vger.kernel.org>,
"Andy Lutomirski" <luto@amacapital.net>,
"Serge E. Hallyn" <serge@hallyn.com>,
"Richard Weinberger" <richard@nod.at>,
"Kenton Varda" <kenton@sandstorm.io>,
"Michael Kerrisk-manpages" <mtk.manpages@gmail.com>,
"Stéphane Graber" <stgraber@ubuntu.com>,
"Eric Windisch" <ewindisch@docker.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Tejun Heo" <tj@kernel.org>,
"Omar Sandoval" <osandov@osandov.com>,
"Ivan Delalande" <colona@arista.com>
Subject: Re: [GIT PULL] User namespace related fixes for v4.2
Date: Mon, 6 Jul 2015 15:47:48 -0500 [thread overview]
Message-ID: <20150706204748.GB22962@ubuntu-hedt> (raw)
In-Reply-To: <878uazhapq.fsf@x220.int.ebiederm.org>
On Wed, Jul 01, 2015 at 03:41:37PM -0500, Eric W. Biederman wrote:
> This set of changes also starts enforcing the mount flags of fresh
> mounts of proc and sysfs are consistent with the existing mount of proc
> and sysfs. I expected this to be the boring part of the work but
> unfortunately unprivileged userspace winds up mounting fresh copies of
> proc and sysfs with noexec and nosuid clear when root set those flags on
> the previous mount of proc and sysfs. So for now only the atime,
> read-only and nodev attributes which userspace happens to keep
> consistent are enforced. Dealing with the noexec and nosuid attributes
> remains for another time.
Sorry to be the bearer of bad news, but I am seeing a regression in lxc
with 4.2-rc1 due to this change. lxc is doing a fresh mount of sysfs
that never specifies either read-only or nodev regardless of how sysfs
has been mounted previously, and this is causing me to see mount
failures because of the nodev check.
If I comment out only the nodev check then the mount works on my system,
but based on the code in lxc I don't think there's any guarantee at all
of this mount having flags consistent with previous mounts.
Seth
next prev parent reply other threads:[~2015-07-06 20:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 20:50 [GIT PULL] User namespace related fixes for v4.2 Eric W. Biederman
2015-06-29 16:43 ` Linus Torvalds
[not found] ` <CA+55aFysKDXr2HEwNzm3z9QOw=E4ZeWcvYQ-xLhy5_k+rGbeRg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-29 21:13 ` Eric W. Biederman
2015-07-03 22:10 ` Linus Torvalds
[not found] ` <CA+55aFw-DK-xDC-3HYa=BMX8WNyQgT9O01tihrAS9+-7PPj_jA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-04 23:11 ` Al Viro
[not found] ` <20150704231118.GT17109-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
2015-07-10 16:16 ` [REVIEW][PATCH 0/2] noexec on proc and sysfs Eric W. Biederman
2015-07-10 16:17 ` [REVIEW][PATCH 1/2] vfs: Commit to never having exectuables " Eric W. Biederman
[not found] ` <87h9pcyokc.fsf_-_-JOvCrm2gF+uungPnsOpG7nhyD016LWXt@public.gmane.org>
2015-07-10 18:24 ` Richard Weinberger
[not found] ` <55A00DE9.7060806-/L3Ra7n9ekc@public.gmane.org>
2015-07-10 19:30 ` Greg Kroah-Hartman
[not found] ` <20150710193052.GB19824-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-07-10 19:38 ` Richard Weinberger
[not found] ` <55A01F4B.9010205-/L3Ra7n9ekc@public.gmane.org>
2015-07-10 20:00 ` Eric W. Biederman
[not found] ` <87mvz4yomp.fsf_-_-JOvCrm2gF+uungPnsOpG7nhyD016LWXt@public.gmane.org>
2015-07-10 16:18 ` [REVIEW][PATCH 2/2] mnt: fs_fully_visible enforce noexec and nosuid if !SB_I_NOEXEC Eric W. Biederman
[not found] ` <87381eyz26.fsf-JOvCrm2gF+uungPnsOpG7nhyD016LWXt@public.gmane.org>
2015-07-01 20:41 ` [GIT PULL] User namespace related fixes for v4.2 Eric W. Biederman
2015-07-06 20:47 ` Seth Forshee [this message]
2015-07-06 21:24 ` Eric W. Biederman
[not found] ` <E81DECCD-9B19-4D42-BE43-5987DE7B05DB-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2015-07-06 22:25 ` Seth Forshee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150706204748.GB22962@ubuntu-hedt \
--to=seth.forshee@canonical.com \
--cc=colona@arista.com \
--cc=containers@lists.linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=ewindisch@docker.com \
--cc=gregkh@linuxfoundation.org \
--cc=kenton@sandstorm.io \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mtk.manpages@gmail.com \
--cc=osandov@osandov.com \
--cc=richard@nod.at \
--cc=serge@hallyn.com \
--cc=stgraber@ubuntu.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).