From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] pci_regs: reintroduce PCI_MSIX_FLAGS_BIRMASK Date: Mon, 13 Jul 2015 18:11:38 +0300 Message-ID: <20150713181025-mutt-send-email-mst@redhat.com> References: <1435745608-21217-1-git-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1435745608-21217-1-git-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Bjorn Helgaas , Rajat Jain , "Chen, Gong" , Guenter Roeck , =?us-ascii?B?PT9VVEYtOD9xP1JhZmE9QzU9ODI9MjBNaT1DNT04MmVja2k/PQ==?= , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-api@vger.kernel.org On Wed, Jul 01, 2015 at 12:14:10PM +0200, Michael S. Tsirkin wrote: > This partially reverts commit 09a2c73ddfc7f173237fc7209a65b34dd5bcb5ed. > PCI: Remove unused PCI_MSIX_FLAGS_BIRMASK definition > > That commit dropped a symbol from an exported header claiming "no one > uses it". This isn't how Linux normally approaches userspace API though, > and in fact QEMU build fails if trying to use updated headers from linux > 3.12 and up. > > Sure, userspace can be fixed to use the new symbol, but the cost > of keeping the old one around is fairly low, too. > > Signed-off-by: Michael S. Tsirkin Ping. Can this be included upstream please? > --- > include/uapi/linux/pci_regs.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h > index efe3443..66644ac 100644 > --- a/include/uapi/linux/pci_regs.h > +++ b/include/uapi/linux/pci_regs.h > @@ -319,6 +319,7 @@ > #define PCI_MSIX_PBA 8 /* Pending Bit Array offset */ > #define PCI_MSIX_PBA_BIR 0x00000007 /* BAR index */ > #define PCI_MSIX_PBA_OFFSET 0xfffffff8 /* Offset into specified BAR */ > +#define PCI_MSIX_FLAGS_BIRMASK PCI_MSIX_PBA_BIR /* deprecated */ > #define PCI_CAP_MSIX_SIZEOF 12 /* size of MSIX registers */ > > /* MSI-X Table entry format */ > -- > MST