Re: [PATCH nf-next] netfilter: nf_ct_sctp: minimal multihoming support

[Pablo Neira Ayuso <pablo-Cap9r6Oaw4JrovVCs/uTlw@public.gmane.org>]

On Tue, Jul 14, 2015 at 06:28:50PM +0200, Michal Kubecek wrote:
> On Tue, Jul 14, 2015 at 05:38:47PM +0200, Pablo Neira Ayuso wrote:
> > On Tue, Jul 14, 2015 at 02:23:11PM +0200, Michal Kubecek wrote:
> > > @@ -658,6 +696,18 @@ static struct ctl_table sctp_sysctl_table[] = {
> > >  		.mode		= 0644,
> > >  		.proc_handler	= proc_dointvec_jiffies,
> > >  	},
> > > +	{
> > > +		.procname	= "nf_conntrack_sctp_timeout_heartbeat_sent",
> > > +		.maxlen		= sizeof(unsigned int),
> > > +		.mode		= 0644,
> > > +		.proc_handler	= proc_dointvec_jiffies,
> > > +	},
> > > +	{
> > > +		.procname	= "nf_conntrack_sctp_timeout_heartbeat_acked",
> > > +		.maxlen		= sizeof(unsigned int),
> > > +		.mode		= 0644,
> > > +		.proc_handler	= proc_dointvec_jiffies,
> > > +	},
> > >  	{ }
> > >  };
> > >  
> > > @@ -705,6 +755,18 @@ static struct ctl_table sctp_compat_sysctl_table[] = {
> > >  		.mode		= 0644,
> > >  		.proc_handler	= proc_dointvec_jiffies,
> > >  	},
> > > +	{
> > > +		.procname	= "ip_conntrack_sctp_timeout_heartbeat_sent",
> > > +		.maxlen		= sizeof(unsigned int),
> > > +		.mode		= 0644,
> > > +		.proc_handler	= proc_dointvec_jiffies,
> > > +	},
> > > +	{
> > > +		.procname	= "ip_conntrack_sctp_timeout_heartbeat_acked",
> > > +		.maxlen		= sizeof(unsigned int),
> > > +		.mode		= 0644,
> > > +		.proc_handler	= proc_dointvec_jiffies,
> > > +	},
> > >  	{ }
> > 
> > I don't see the nla_policy updates for the netlink cttimeout
> > interface.
> 
> I didn't realize those were needed. It means adding two entries to
> sctp_timeout_nla_policy and two values to enum ctattr_timeout_sctp?

Exactly.