[linux-4.2-rc3/tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c:194: bad if condition ?

[linux-4.2-rc3/tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c:194: bad if condition ?

[David Binderman]

Hello there,

[linux-4.2-rc3/tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c:194]: (style) Expression is always false because 'else if' condition matches previous condition at line 191.

Source code is

        if (res> 0) {
            atomic_set(&requeued, 1);
            break;
        } else if (res> 0) {

Regards

David Binderman

 		 	   		  --
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [linux-4.2-rc3/tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c:194: bad if condition ?

[Shuah Khan]

On 07/20/2015 03:26 AM, David Binderman wrote:
> Hello there,
> 
> [linux-4.2-rc3/tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c:194]: (style) Expression is always false because 'else if' condition matches previous condition at line 191.
> 
> Source code is
> 
>         if (res> 0) {
>             atomic_set(&requeued, 1);
>             break;
>         } else if (res> 0) {
> 

Hi Daren,

Is this something that could be fixed?

thanks,
-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978

Re: [linux-4.2-rc3/tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c:194: bad if condition ?

[Cyril Hrubis]

Hi!
> > [linux-4.2-rc3/tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c:194]: (style) Expression is always false because 'else if' condition matches previous condition at line 191.
> > 
> > Source code is
> > 
> >         if (res> 0) {
> >             atomic_set(&requeued, 1);
> >             break;
> >         } else if (res> 0) {
> > 
> 
> Hi Daren,
> 
> Is this something that could be fixed?

Looks like a typo to me. My guess is that it should have been:

...
} else if (res < 0) {
...

-- 
Cyril Hrubis
chrubis-AlSwsSmVLrQ@public.gmane.org

Re: [linux-4.2-rc3/tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c:194: bad if condition ?

[Darren Hart]

On Mon, Jul 20, 2015 at 08:42:16AM -0600, Shuah Khan wrote:
> On 07/20/2015 03:26 AM, David Binderman wrote:
> > Hello there,
> > 
> > [linux-4.2-rc3/tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c:194]: (style) Expression is always false because 'else if' condition matches previous condition at line 191.
> > 
> > Source code is
> > 
> >         if (res> 0) {
> >             atomic_set(&requeued, 1);
> >             break;
> >         } else if (res> 0) {
> > 
> 
> Hi Daren,
> 
> Is this something that could be fixed?

Ew, yuck. I'll look into this and provide a fix.

Thanks for the report David.

-- 
Darren Hart
Intel Open Source Technology Center