From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darren Hart Subject: Re: [linux-4.2-rc3/tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c:194: bad if condition ? Date: Mon, 20 Jul 2015 14:03:57 -0700 Message-ID: <20150720210357.GB99388@vmdeb7> References: <55AD08C8.4030705@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <55AD08C8.4030705-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Shuah Khan Cc: "linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , David Binderman List-Id: linux-api@vger.kernel.org On Mon, Jul 20, 2015 at 08:42:16AM -0600, Shuah Khan wrote: > On 07/20/2015 03:26 AM, David Binderman wrote: > > Hello there, > > > > [linux-4.2-rc3/tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c:194]: (style) Expression is always false because 'else if' condition matches previous condition at line 191. > > > > Source code is > > > > if (res> 0) { > > atomic_set(&requeued, 1); > > break; > > } else if (res> 0) { > > > > Hi Daren, > > Is this something that could be fixed? Ew, yuck. I'll look into this and provide a fix. Thanks for the report David. -- Darren Hart Intel Open Source Technology Center