* [linux-4.2-rc3/tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c:194: bad if condition ?
@ 2015-07-20 9:26 David Binderman
[not found] ` <DUB128-W55FA5DB7B71A53D5E73E289C850-MsuGFMq8XAE@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: David Binderman @ 2015-07-20 9:26 UTC (permalink / raw)
To: Shuah Khan, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Hello there,
[linux-4.2-rc3/tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c:194]: (style) Expression is always false because 'else if' condition matches previous condition at line 191.
Source code is
if (res> 0) {
atomic_set(&requeued, 1);
break;
} else if (res> 0) {
Regards
David Binderman
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread[parent not found: <DUB128-W55FA5DB7B71A53D5E73E289C850-MsuGFMq8XAE@public.gmane.org>]
* Re: [linux-4.2-rc3/tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c:194: bad if condition ? [not found] ` <DUB128-W55FA5DB7B71A53D5E73E289C850-MsuGFMq8XAE@public.gmane.org> @ 2015-07-20 14:42 ` Shuah Khan [not found] ` <55AD08C8.4030705-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Shuah Khan @ 2015-07-20 14:42 UTC (permalink / raw) To: linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Darren Hart Cc: David Binderman On 07/20/2015 03:26 AM, David Binderman wrote: > Hello there, > > [linux-4.2-rc3/tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c:194]: (style) Expression is always false because 'else if' condition matches previous condition at line 191. > > Source code is > > if (res> 0) { > atomic_set(&requeued, 1); > break; > } else if (res> 0) { > Hi Daren, Is this something that could be fixed? thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978 ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <55AD08C8.4030705-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>]
* Re: [linux-4.2-rc3/tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c:194: bad if condition ? [not found] ` <55AD08C8.4030705-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> @ 2015-07-20 15:09 ` Cyril Hrubis 2015-07-20 21:03 ` Darren Hart 1 sibling, 0 replies; 4+ messages in thread From: Cyril Hrubis @ 2015-07-20 15:09 UTC (permalink / raw) To: Shuah Khan Cc: linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Darren Hart, David Binderman Hi! > > [linux-4.2-rc3/tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c:194]: (style) Expression is always false because 'else if' condition matches previous condition at line 191. > > > > Source code is > > > > if (res> 0) { > > atomic_set(&requeued, 1); > > break; > > } else if (res> 0) { > > > > Hi Daren, > > Is this something that could be fixed? Looks like a typo to me. My guess is that it should have been: ... } else if (res < 0) { ... -- Cyril Hrubis chrubis-AlSwsSmVLrQ@public.gmane.org ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [linux-4.2-rc3/tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c:194: bad if condition ? [not found] ` <55AD08C8.4030705-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> 2015-07-20 15:09 ` Cyril Hrubis @ 2015-07-20 21:03 ` Darren Hart 1 sibling, 0 replies; 4+ messages in thread From: Darren Hart @ 2015-07-20 21:03 UTC (permalink / raw) To: Shuah Khan Cc: linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Binderman On Mon, Jul 20, 2015 at 08:42:16AM -0600, Shuah Khan wrote: > On 07/20/2015 03:26 AM, David Binderman wrote: > > Hello there, > > > > [linux-4.2-rc3/tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c:194]: (style) Expression is always false because 'else if' condition matches previous condition at line 191. > > > > Source code is > > > > if (res> 0) { > > atomic_set(&requeued, 1); > > break; > > } else if (res> 0) { > > > > Hi Daren, > > Is this something that could be fixed? Ew, yuck. I'll look into this and provide a fix. Thanks for the report David. -- Darren Hart Intel Open Source Technology Center ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-20 21:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-20 9:26 [linux-4.2-rc3/tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c:194: bad if condition ? David Binderman
[not found] ` <DUB128-W55FA5DB7B71A53D5E73E289C850-MsuGFMq8XAE@public.gmane.org>
2015-07-20 14:42 ` Shuah Khan
[not found] ` <55AD08C8.4030705-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2015-07-20 15:09 ` Cyril Hrubis
2015-07-20 21:03 ` Darren Hart
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).